Skip to content

fix(opensearchservice): add i8g nodes validation without EBS #35668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2025
Merged

fix(opensearchservice): add i8g nodes validation without EBS #35668

merged 6 commits into from
Oct 21, 2025

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Oct 3, 2025 •
edited
Loading

Issue # (if applicable)

Closes #35666.

Reason for this change

Cannot create i8g data nodes without EBS due to validation logic.

Description of changes

Enable create i8g data nodes by adding i8g type to unSupportEbsInstanceType .

Describe any new or updated permissions being added

N/A

Description of how you validated changes

unit test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 3, 2025 04:06
@github-actions github-actions bot added bug This issue is a bug. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Oct 3, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 3, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mazyu36 mazyu36 changed the title fix(opensearchservice): cannot i8g data nodes without EBS fix(opensearchservice): cannot i8g data nodes without EBS Oct 3, 2025
@mazyu36
Copy link
Contributor Author

mazyu36 commented Oct 3, 2025

Exemption Request: Unit tests sufficiently verify that no errors occur when using i8n without ebs.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 3, 2025
@pahud pahud mentioned this pull request Oct 3, 2025
Closed
1 task
taesungh
taesungh approved these changes Oct 6, 2025
View reviewed changes
Copy link

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@ozelalisen ozelalisen self-assigned this Oct 20, 2025
@ozelalisen ozelalisen added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Oct 20, 2025
@ozelalisen ozelalisen removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 20, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 20, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 20, 2025 14:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@ozelalisen ozelalisen changed the title fix(opensearchservice): cannot i8g data nodes without EBS fix(opensearchservice): add i8g nodes validation without EBS Oct 20, 2025
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Oct 20, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 20, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 20, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added dequeued and removed queued labels Oct 20, 2025
@mazyu36
Copy link
Contributor Author

mazyu36 commented Oct 20, 2025

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 20, 2025

update

✅ Branch has been successfully updated

@mergify mergify bot removed the dequeued label Oct 20, 2025
@mazyu36
Copy link
Contributor Author

mazyu36 commented Oct 21, 2025

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 21, 2025

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 21, 2025
@mergify mergify bot merged commit 9594842 into aws:main Oct 21, 2025
18 of 19 checks passed
@mergify mergify bot removed the queued label Oct 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ozelalisen ozelalisen ozelalisen approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@taesungh taesungh taesungh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ozelalisen ozelalisen

Labels

bug This issue is a bug. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(opensearchservice): Cannot create domain with I8g data nodes without EBS, validation error

4 participants

@mazyu36 @aws-cdk-automation @taesungh @ozelalisen