Segreggating context errors #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauxs
commented
Jun 6, 2024
| if err == context.Canceled { | ||
| return awserr.New(request.CanceledErrorCode, "request context canceled", err) | ||
| } else if err == context.DeadlineExceeded { | ||
| return awserr.New(request.CanceledErrorCode, "request context deadline exceeded", err) |
There was a problem hiding this comment.
Have to change from CanceledErrorCode -> DeadlineExceededErrorCode but aws-sdk-go went in maintenace mode and aws-sdk-go-v2 handles error differently
|
@narosivi please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Our DAX got latent and context started getting deadline exceeded. Below is the message which we were logging in our server:
error ddb/de_entity_generic_get.go:99 couldn't get item {"id": "b1ace8e8-7f7a-4e44-af2a-4a4378ee1816", "table": "de-entity-map", "pk": "********", "sk": "********", "error": "RequestCanceled: request context canceled\ncaused by: context deadline exceeded”}Breaking down the error log:
context deadline exceeded- This is received from DAX serverRequestCanceled: request context canceled- This is generated by aws-dax-go client.We can see that the error log is misleading.
Description of changes:
ctx.Err() can return either
CanceledorDeadlineExceeded, generating error message based on the error type.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.