Add build-time option to opt-out of CPU Jitter Entropy #2733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2733 +/- ##
==========================================
- Coverage 78.93% 78.93% -0.01%
==========================================
Files 675 675
Lines 115273 115283 +10
Branches 16210 16213 +3
==========================================
+ Hits 90994 91001 +7
- Misses 23489 23493 +4
+ Partials 790 789 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Oct 8, 2025
torben-hansen
force-pushed
the
opt_out_cpu_jitter_entropy
branch
from
a6b4d30 to
fa26eec
Compare
justsmth
reviewed
Oct 9, 2025
justsmth
reviewed
Oct 10, 2025
justsmth
previously approved these changes
Oct 10, 2025
torben-hansen
force-pushed
the
opt_out_cpu_jitter_entropy
branch
from
080161d to
d5b0d84
Compare
justsmth
approved these changes
Oct 13, 2025
skmcgrail
approved these changes
Oct 13, 2025
Merged
justsmth
added a commit
that referenced
this pull request
Oct 13, 2025
### Description of changes: Prepare v1.62.0 release #### What's Changed * nginx now supports AWS-LC by @samuel40791765 in #2714 * Fix tests that assume X25519 will be negotiated by @alexw91 in #2682 * Fixing a bug in ML-DSA poly_uniform function by @dkostic in #2721 * Migrate integration omnibus by @skmcgrail in #2715 * Delete util/bot directory by @justsmth in #2723 * Don't ignore CMAKE_C_FLAGS w/ MSVC by @justsmth in #2722 * Bump urllib3 from 2.2.3 to 2.5.0 in /tests/ci by @dependabot[bot] in #2551 * Type fix in mldsa by @manastasova in #2308 * Centralize password handling tool-openssl by @kingstjo in #2555 * crypto/pem: replace strncmp with CRYPTO_memcmp to fix -Wstring-compare error by @R3hankhan123 in #2724 * Implement dgst CLI command by @nhatnghiho in #2638 * Add ASN.1 decoding for ML-KEM private keys as seeds by @jakemas in #2707 * Implement genrsa command by @kingstjo in #2535 * Move udiv and sencond tweak calculations to when needed by @nebeid in #2726 * Add null check on RSA key checks by @samuel40791765 in #2727 * Implement workaround for FORTIFY_SOURCE warning with jitterentropy by @skmcgrail in #2728 * Implement coverity suggestions by @skmcgrail in #2730 * Add minimal EC CLI tool implementation by @kingstjo in #2640 * Adding pkeyutl tool to the CLI by @smittals2 in #2575 * Add CI dimensions for legacy AVX512 flags by @smittals2 in #2732 * Fix Libwebsockets CI by @smittals2 in #2737 * Add option ENABLE_SOURCE_MODIFICATION by @justsmth in #2739 * Simple script to build/run tests by @justsmth in #2736 * Add build-time option to opt-out of CPU Jitter Entropy by @torben-hansen in #2733 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
D315146529
Description of changes:
Adds a build-time option
DISABLE_USAGE_OF_CPU_JITTER_ENTROPYto opt-out of CPU Jitter Entropy. That is, with this option CPU Jitter Entropy will never be configured, the tree-DRBG will not be used. Furthermore, CPU Jitter Entropy will not even be included in any compilation units.When using
DISABLE_USAGE_OF_CPU_JITTER_ENTROPYwe can no longer guarantee two entropy sources because only the Operating System type will be required to be available. rdrand and rndr will be used if supported in any given run-time, but it's not a guarantee.Testing:
New stanza in build script executes a complete build and test with the option.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.