Xaes 256 gcm #2740

ttungle96 · 2025-10-09T21:54:55Z

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 14. Check the log or trigger a new build to see more.

github-actions · 2025-10-09T22:03:07Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX ctx;
+    ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key.data(), key.size(), tag_size, nullptr));
+
+    size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1622:

- en; + en = 0;

github-actions · 2025-10-09T22:03:07Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX dctx;
+	ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm(), key.data(), key.size(), tag_size, nullptr));
+
+	size_t plaintext_len;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1631:

- en; + en = 0;

github-actions · 2025-10-09T22:03:07Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX ctx;
+    ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm_key_commit(), key.data(), key.size(), tag_size, nullptr));
+
+    size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1666:

- en; + en = 0;

github-actions · 2025-10-09T22:03:07Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX dctx;
+	ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm_key_commit(), key.data(), key.size(), tag_size, nullptr));
+
+	size_t plaintext_len;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1675:

- en; + en = 0;

github-actions · 2025-10-09T22:03:08Z

crypto/cipher_extra/cipher_test.cc

-  CHECK_ERROR(EVP_EncryptFinal(ctx.get(), out_vec.data(), &out_len), ERR_R_SHOULD_NOT_HAVE_BEEN_CALLED);
-  CHECK_ERROR(EVP_DecryptUpdate(ctx.get(), out_vec.data(), &out_len, in_vec.data(), in_len), ERR_R_SHOULD_NOT_HAVE_BEEN_CALLED);
-  CHECK_ERROR(EVP_DecryptFinal(ctx.get(), out_vec.data(), &out_len), ERR_R_SHOULD_NOT_HAVE_BEEN_CALLED);
+    int ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

int ciphertext_len;

= 0

github-actions · 2025-10-09T22:03:08Z

crypto/cipher_extra/cipher_test.cc

+    int ciphertext_len;
+    ASSERT_TRUE(EVP_CipherUpdate(ctx.get(), (uint8_t*)ciphertext.data(), &ciphertext_len, 
+                plaintext.data(), plaintext.size()));
+    int len;


warning: variable 'len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

int len;

= 0

github-actions · 2025-10-09T22:03:08Z

crypto/cipher_extra/cipher_test.cc

+    ASSERT_EQ((size_t)aad_len, aad.size());
+
+    len = 0;
+    plaintext_len = 0;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1537: Value stored to 'plaintext_len' is never read

^

github-actions · 2025-10-09T22:03:08Z

crypto/cipher_extra/cipher_test.cc

+    int aad_len = aad.size();
+    ASSERT_EQ(aad_len, EVP_Cipher(ctx.get(), NULL, aad.data(), aad_len));
+
+    int ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

int ciphertext_len;

= 0

github-actions · 2025-10-09T22:03:08Z

crypto/cipher_extra/cipher_test.cc

+    int ciphertext_len;
+    ASSERT_TRUE(EVP_CipherUpdate(ctx.get(), (uint8_t*)ciphertext.data(), &ciphertext_len, 
+                plaintext.data(), plaintext.size()));
+    int len;


warning: variable 'len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

int len;

= 0

github-actions · 2025-10-09T22:03:08Z

crypto/cipher_extra/cipher_test.cc

+    ASSERT_EQ((size_t)aad_len, aad.size());
+
+    len = 0;
+    plaintext_len = 0;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1634: Value stored to 'plaintext_len' is never read

^

github-actions

clang-tidy made some suggestions

github-actions · 2025-10-09T23:21:54Z

crypto/fipsmodule/cipher/e_aes.c

+}
+
+DEFINE_METHOD_FUNCTION(EVP_CIPHER, EVP_xaes_256_gcm) {
+    memset(out, 0, sizeof(EVP_CIPHER));


warning: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]

memset(out, 0, sizeof(EVP_CIPHER)); ^

Additional context

crypto/fipsmodule/cipher/e_aes.c:1896: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11

memset(out, 0, sizeof(EVP_CIPHER)); ^

We have an OPENSSL_memset that should be used internally.

Thank you for letting me know!

github-actions · 2025-10-09T23:21:54Z

crypto/fipsmodule/cipher/e_aes.c

+}
+
+DEFINE_METHOD_FUNCTION(EVP_CIPHER, EVP_xaes_256_gcm_key_commit) {
+    memset(out, 0, sizeof(EVP_CIPHER));


warning: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]

memset(out, 0, sizeof(EVP_CIPHER)); ^

Additional context

crypto/fipsmodule/cipher/e_aes.c:1969: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11

memset(out, 0, sizeof(EVP_CIPHER)); ^

github-actions · 2025-10-09T23:21:54Z

crypto/fipsmodule/cipher/e_aes.c

+}
+
+DEFINE_METHOD_FUNCTION(EVP_AEAD, EVP_aead_xaes_256_gcm) {
+    memset(out, 0, sizeof(EVP_AEAD));


warning: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]

memset(out, 0, sizeof(EVP_AEAD)); ^

Additional context

crypto/fipsmodule/cipher/e_aes.c:2076: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11

memset(out, 0, sizeof(EVP_AEAD)); ^

github-actions · 2025-10-09T23:21:54Z

crypto/fipsmodule/cipher/e_aes.c

+}
+
+DEFINE_METHOD_FUNCTION(EVP_AEAD, EVP_aead_xaes_256_gcm_key_commit) {
+    memset(out, 0, sizeof(EVP_AEAD));


warning: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]

memset(out, 0, sizeof(EVP_AEAD)); ^

Additional context

crypto/fipsmodule/cipher/e_aes.c:2157: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11

memset(out, 0, sizeof(EVP_AEAD)); ^

codecov-commenter · 2025-10-09T23:51:57Z

Codecov Report

❌ Patch coverage is 91.85804% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.98%. Comparing base (483d379) to head (6b4aab5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crypto/fipsmodule/cipher/e_aes.c	86.79%	28 Missing ⚠️
crypto/test/test_util.cc	33.33%	6 Missing and 2 partials ⚠️
crypto/cipher_extra/cipher_test.cc	98.69%	2 Missing ⚠️
crypto/fipsmodule/cipher/aead.c	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2740      +/-   ##
==========================================
+ Coverage   78.89%   78.98%   +0.08%     
==========================================
  Files         677      677              
  Lines      115526   116001     +475     
  Branches    16249    16288      +39     
==========================================
+ Hits        91150    91618     +468     
- Misses      23579    23584       +5     
- Partials      797      799       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions

clang-tidy made some suggestions

github-actions · 2025-10-10T00:41:36Z

crypto/fipsmodule/cipher/e_aes.c

+}
+
+DEFINE_METHOD_FUNCTION(EVP_CIPHER, EVP_xaes_256_gcm) {
+    memset(out, 0, sizeof(EVP_CIPHER));


warning: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]

memset(out, 0, sizeof(EVP_CIPHER)); ^

Additional context

crypto/fipsmodule/cipher/e_aes.c:1904: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11

memset(out, 0, sizeof(EVP_CIPHER)); ^

github-actions · 2025-10-10T00:41:37Z

crypto/fipsmodule/cipher/e_aes.c

+}
+
+DEFINE_METHOD_FUNCTION(EVP_CIPHER, EVP_xaes_256_gcm_key_commit) {
+    memset(out, 0, sizeof(EVP_CIPHER));


warning: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]

memset(out, 0, sizeof(EVP_CIPHER)); ^

Additional context

crypto/fipsmodule/cipher/e_aes.c:1967: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11

memset(out, 0, sizeof(EVP_CIPHER)); ^

github-actions · 2025-10-10T00:41:37Z

crypto/fipsmodule/cipher/e_aes.c

+}
+
+DEFINE_METHOD_FUNCTION(EVP_AEAD, EVP_aead_xaes_256_gcm) {
+    memset(out, 0, sizeof(EVP_AEAD));


warning: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]

memset(out, 0, sizeof(EVP_AEAD)); ^

Additional context

crypto/fipsmodule/cipher/e_aes.c:2074: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11

memset(out, 0, sizeof(EVP_AEAD)); ^

github-actions · 2025-10-10T00:41:37Z

crypto/fipsmodule/cipher/e_aes.c

+}
+
+DEFINE_METHOD_FUNCTION(EVP_AEAD, EVP_aead_xaes_256_gcm_key_commit) {
+    memset(out, 0, sizeof(EVP_AEAD));


warning: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]

memset(out, 0, sizeof(EVP_AEAD)); ^

Additional context

crypto/fipsmodule/cipher/e_aes.c:2155: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11

memset(out, 0, sizeof(EVP_AEAD)); ^

github-actions

clang-tidy made some suggestions

github-actions · 2025-10-10T02:38:50Z

crypto/fipsmodule/cipher/e_aes.c

+}
+
+DEFINE_METHOD_FUNCTION(EVP_CIPHER, EVP_xaes_256_gcm) {
+    memset(out, 0, sizeof(EVP_CIPHER));


warning: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]

memset(out, 0, sizeof(EVP_CIPHER)); ^

Additional context

crypto/fipsmodule/cipher/e_aes.c:1906: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11

memset(out, 0, sizeof(EVP_CIPHER)); ^

github-actions

clang-tidy made some suggestions

github-actions · 2025-10-13T00:47:50Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX ctx;
+    ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+    size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1716:

- en; + en = 0;

github-actions · 2025-10-13T00:47:50Z

crypto/cipher_extra/cipher_test.cc

+        ASSERT_TRUE(EVP_CIPHER_CTX_ctrl(ctx.get(), EVP_CTRL_AEAD_SET_IVLEN, 24, NULL));
+        ASSERT_TRUE(EVP_CipherInit_ex(ctx.get(), NULL, NULL, key, nonce, -1));
+
+        int ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

int ciphertext_len;

= 0

github-actions · 2025-10-13T00:47:50Z

crypto/cipher_extra/cipher_test.cc

+        ASSERT_TRUE(EVP_CipherUpdate(ctx.get(), (uint8_t*)ciphertext.data(), &ciphertext_len, 
+                    plaintext, plaintext_len));
+
+        int len;


warning: variable 'len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

int len;

= 0

github-actions · 2025-10-13T00:47:50Z

crypto/cipher_extra/cipher_test.cc

+        int aad_len = aad.size();
+        ASSERT_EQ(aad_len, EVP_Cipher(ctx.get(), NULL, aad.data(), aad_len));
+
+        int ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

int ciphertext_len;

= 0

github-actions · 2025-10-13T00:47:50Z

crypto/cipher_extra/cipher_test.cc

+        ASSERT_TRUE(EVP_CipherUpdate(ctx.get(), (uint8_t*)ciphertext.data(), &ciphertext_len, 
+                    plaintext.data(), plaintext.size()));
+
+        int len;


warning: variable 'len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

int len;

= 0

github-actions · 2025-10-13T00:47:51Z

crypto/cipher_extra/cipher_test.cc

+        ASSERT_EQ((size_t)aad_len, aad.size());
+
+        len = 0;
+        size_t plaintext_len;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

size_t plaintext_len;

= 0

github-actions · 2025-10-13T00:47:51Z

crypto/cipher_extra/cipher_test.cc

+
+        decrypted.resize(plaintext.size());
+        len = 0;
+        plaintext_len = 0;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1617: Value stored to 'plaintext_len' is never read

^

github-actions · 2025-10-13T00:47:51Z

crypto/cipher_extra/cipher_test.cc

+
+        plaintext_len = len;
+        ASSERT_TRUE(EVP_DecryptFinal(dctx.get(), (uint8_t*)decrypted.data() + len, &len));
+        plaintext_len += len;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1622: Value stored to 'plaintext_len' is never read

^

github-actions · 2025-10-13T00:47:51Z

crypto/cipher_extra/cipher_test.cc

+    ASSERT_EQ((size_t)aad_len, aad.size());
+
+    len = 0;
+    plaintext_len = 0;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1715: Value stored to 'plaintext_len' is never read

^

…to XAES_256_GCM

github-actions

clang-tidy made some suggestions

github-actions · 2025-10-13T16:40:36Z

crypto/cipher_extra/aead_test.cc

+        bssl::ScopedEVP_AEAD_CTX ctx;
+        ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+        size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1628:

- en; + en = 0;

github-actions · 2025-10-13T16:40:36Z

crypto/cipher_extra/aead_test.cc

+        bssl::ScopedEVP_AEAD_CTX ctx;
+        ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key.data(), key.size(), tag_size, nullptr));
+
+        size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1660:

- en; + en = 0;

github-actions · 2025-10-13T16:40:36Z

crypto/cipher_extra/aead_test.cc

+        bssl::ScopedEVP_AEAD_CTX dctx;
+        ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm(), key.data(), key.size(), tag_size, nullptr));
+
+        size_t plaintext_len;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1674:

- en; + en = 0;

github-actions · 2025-10-13T16:40:36Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX ctx;
+    ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm_key_commit(), key.data(), key.size(), tag_size, nullptr));
+
+    size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1715:

- en; + en = 0;

github-actions · 2025-10-13T16:40:36Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX dctx;
+	ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm_key_commit(), key.data(), key.size(), tag_size, nullptr));
+
+	size_t plaintext_len;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1724:

- en; + en = 0;

github-actions · 2025-10-13T16:40:37Z

crypto/obj/obj_dat.h

-#define NUM_NID 999
+#define NUM_NID 1001

 static const uint8_t kObjectData[] = {


warning: unknown type name 'uint8_t' [clang-diagnostic-error]

static const uint8_t kObjectData[] = { ^

github-actions · 2025-10-13T16:40:37Z

crypto/obj/obj_dat.h

+    0x32,
 };

 static const ASN1_OBJECT kObjects[NUM_NID] = {


warning: unknown type name 'ASN1_OBJECT' [clang-diagnostic-error]

static const ASN1_OBJECT kObjects[NUM_NID] = { ^

github-actions

clang-tidy made some suggestions

github-actions · 2025-10-13T17:29:11Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX dctx;
+	ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm_key_commit(), key.data(), key.size(), tag_size, nullptr));
+
+	size_t plaintext_len;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1728:

- en; + en = 0;

github-actions · 2025-10-13T17:29:12Z

crypto/cipher_extra/cipher_test.cc

+    ASSERT_EQ((size_t)aad_len, aad.size());
+
+    len = 0;
+    plaintext_len = 0;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1738: Value stored to 'plaintext_len' is never read

^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 16. Check the log or trigger a new build to see more.

github-actions · 2025-10-13T22:58:39Z

crypto/cipher_extra/aead_test.cc

+        bssl::ScopedEVP_AEAD_CTX ctx;
+        ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+        size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1630:

- en; + en = 0;

github-actions · 2025-10-13T22:58:39Z

crypto/cipher_extra/aead_test.cc

+        bssl::ScopedEVP_AEAD_CTX ctx;
+        ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key.data(), key.size(), tag_size, nullptr));
+
+        size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1661:

- en; + en = 0;

github-actions · 2025-10-13T22:58:39Z

crypto/cipher_extra/aead_test.cc

+        bssl::ScopedEVP_AEAD_CTX dctx;
+        ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm(), key.data(), key.size(), tag_size, nullptr));
+
+        size_t plaintext_len;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1675:

- en; + en = 0;

github-actions · 2025-10-13T22:58:39Z

crypto/cipher_extra/aead_test.cc

+            bssl::ScopedEVP_AEAD_CTX ctx;
+            ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+            size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1729:

- en; + en = 0;

github-actions · 2025-10-13T22:58:39Z

crypto/cipher_extra/aead_test.cc

+            bssl::ScopedEVP_AEAD_CTX dctx;
+            ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+            size_t plaintext_len;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1740:

- en; + en = 0;

github-actions · 2025-10-13T22:58:39Z

crypto/cipher_extra/aead_test.cc

+            bssl::ScopedEVP_AEAD_CTX ctx;
+            ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+            size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1780:

- en; + en = 0;

github-actions · 2025-10-13T22:58:40Z

crypto/cipher_extra/aead_test.cc

+            bssl::ScopedEVP_AEAD_CTX dctx;
+            ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+            size_t plaintext_len;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1791:

- en; + en = 0;

github-actions · 2025-10-13T22:58:40Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX ctx;
+    ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm_key_commit(), key.data(), key.size(), tag_size, nullptr));
+
+    size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1819:

- en; + en = 0;

github-actions · 2025-10-13T22:58:40Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX dctx;
+	ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm_key_commit(), key.data(), key.size(), tag_size, nullptr));
+
+	size_t plaintext_len;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1832:

- en; + en = 0;

github-actions · 2025-10-13T22:58:40Z

crypto/cipher_extra/cipher_test.cc

+
+        decrypted.resize(plaintext.size());
+        len = 0;
+        plaintext_len = 0;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1604: Value stored to 'plaintext_len' is never read

^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 18. Check the log or trigger a new build to see more.

github-actions · 2025-10-13T23:06:30Z

crypto/cipher_extra/aead_test.cc

+        bssl::ScopedEVP_AEAD_CTX ctx;
+        ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+        size_t ciphertext_len;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1629:

- en; + en = 0;

github-actions · 2025-10-13T23:06:30Z

crypto/cipher_extra/aead_test.cc

+            bssl::ScopedEVP_AEAD_CTX ctx;
+            ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+            size_t ciphertext_len = 0;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1728:

- en; + en = 0;

github-actions · 2025-10-13T23:06:30Z

crypto/cipher_extra/aead_test.cc

+            bssl::ScopedEVP_AEAD_CTX dctx;
+            ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+            size_t plaintext_len = 0;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1739:

- en; + en = 0;

github-actions · 2025-10-13T23:06:30Z

crypto/cipher_extra/aead_test.cc

+            bssl::ScopedEVP_AEAD_CTX ctx;
+            ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+            size_t ciphertext_len = 0;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1779:

- en; + en = 0;

github-actions · 2025-10-13T23:06:30Z

crypto/cipher_extra/aead_test.cc

+            bssl::ScopedEVP_AEAD_CTX dctx;
+            ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm(), key, 32, tag_size, nullptr));
+
+            size_t plaintext_len = 0;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1790:

- en; + en = 0;

github-actions · 2025-10-13T23:06:30Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX ctx;
+    ASSERT_TRUE(EVP_AEAD_CTX_init(ctx.get(), EVP_aead_xaes_256_gcm_key_commit(), key.data(), key.size(), tag_size, nullptr));
+
+    size_t ciphertext_len = 0;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1818:

- en; + en = 0;

github-actions · 2025-10-13T23:06:31Z

crypto/cipher_extra/aead_test.cc

+    bssl::ScopedEVP_AEAD_CTX dctx;
+	ASSERT_TRUE(EVP_AEAD_CTX_init(dctx.get(), EVP_aead_xaes_256_gcm_key_commit(), key.data(), key.size(), tag_size, nullptr));
+
+	size_t plaintext_len = 0;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

crypto/cipher_extra/aead_test.cc:1831:

- en; + en = 0;

github-actions · 2025-10-13T23:06:31Z

crypto/cipher_extra/cipher_test.cc

+        ASSERT_TRUE(EVP_CIPHER_CTX_ctrl(ctx.get(), EVP_CTRL_AEAD_SET_IVLEN, iv.size(), NULL));
+        ASSERT_TRUE(EVP_CipherInit_ex(ctx.get(), NULL, NULL, key.data(), iv.data(), -1));
+
+        int ciphertext_len = 0;


warning: variable 'ciphertext_len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

int ciphertext_len = 0;

= 0

github-actions · 2025-10-13T23:06:31Z

crypto/cipher_extra/cipher_test.cc

+        std::vector<uint8_t> decrypted;
+        decrypted.resize(plaintext.size());
+        len = 0;
+        size_t plaintext_len = 0;


warning: variable 'plaintext_len' is not initialized [cppcoreguidelines-init-variables]

Suggested change

size_t plaintext_len = 0;

= 0

github-actions · 2025-10-13T23:06:31Z

crypto/cipher_extra/cipher_test.cc

+
+        decrypted.resize(plaintext.size());
+        len = 0;
+        plaintext_len = 0;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1603: Value stored to 'plaintext_len' is never read

^

github-actions

clang-tidy made some suggestions

github-actions · 2025-10-13T23:10:47Z

crypto/cipher_extra/cipher_test.cc

+
+        plaintext_len = len;
+        ASSERT_TRUE(EVP_DecryptFinal(dctx.get(), (uint8_t*)decrypted.data() + len, &len));
+        plaintext_len += len;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1608: Value stored to 'plaintext_len' is never read

^

github-actions · 2025-10-13T23:10:47Z

crypto/cipher_extra/cipher_test.cc

+    ASSERT_EQ((size_t)aad_len, aad.size());
+
+    len = 0;
+    plaintext_len = 0;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1863: Value stored to 'plaintext_len' is never read

^

github-actions

clang-tidy made some suggestions

github-actions · 2025-10-13T23:15:47Z

crypto/cipher_extra/cipher_test.cc

+    ASSERT_EQ((size_t)aad_len, aad.size());
+
+    len = 0;
+    plaintext_len = 0;


warning: Value stored to 'plaintext_len' is never read [clang-analyzer-deadcode.DeadStores]

^

Additional context

crypto/cipher_extra/cipher_test.cc:1859: Value stored to 'plaintext_len' is never read

^

ttungle96 added 15 commits October 7, 2025 09:39

update

e5322ac

simple test case

ac17c47

update

1a5a7ff

update

5892efc

Key Commitment EVP Cipher

6f5382c

Key Commitment EVP Cipher

5a67519

avoid code duplicates

87b0145

update key commitment

19c0461

update

e886ca8

update

d3ac240

update

7932e30

update

c49476e

update

ecf9ac6

update

0dbd50d

update

7b911bb

github-actions bot reviewed Oct 9, 2025

View reviewed changes

ttungle96 added 2 commits October 9, 2025 15:56

Fix errors

7623aae

Add comments

72a60f5

github-actions bot reviewed Oct 9, 2025

View reviewed changes

fix errors

4a18741

github-actions bot reviewed Oct 10, 2025

View reviewed changes

ttungle96 added 5 commits October 9, 2025 17:42

fix errors

617639f

fix errors

3ff02ea

experimental commit

8f31323

experimental commit

7565dd9

experimental commit

d2e0a61

github-actions bot reviewed Oct 10, 2025

View reviewed changes

ttungle96 added 2 commits October 9, 2025 19:57

experimental commit

4a9cf7f

experimental commit

a69029b

ttungle96 added 7 commits October 10, 2025 09:31

experimental commit

752ef69

Print Errors

b5423cd

Print Errors

6d114da

Print Errors

14230c4

Fix Memory Alignment

e238da3

Final

df1764a

Final

0024af7

github-actions bot reviewed Oct 13, 2025

View reviewed changes

ttungle96 and others added 5 commits October 12, 2025 17:48

Final

5ad24fc

Merge branch 'main' into XAES_256_GCM

fd8ef6e

Merge branch 'main' into XAES_256_GCM

1cc4f04

Adding NIDs

68e8049

Merge branch 'XAES_256_GCM' of https://github.com/ttungle96/aws-lc in…

ad57e2e

…to XAES_256_GCM

github-actions bot reviewed Oct 13, 2025

View reviewed changes

Edit tests

f110578

github-actions bot reviewed Oct 13, 2025

View reviewed changes

ttungle96 added 2 commits October 13, 2025 10:58

Final

1717b0b

Test vectors

d489343

github-actions bot reviewed Oct 13, 2025

View reviewed changes

ttungle96 added 2 commits October 13, 2025 16:01

Final

7224f1d

Final

507f996

github-actions bot reviewed Oct 13, 2025

View reviewed changes

Final

abb7773

github-actions bot reviewed Oct 13, 2025

View reviewed changes

ttungle96 added 4 commits October 13, 2025 16:17

Final

420e4b8

Final

0a87a8e

Merge branch 'main' into XAES_256_GCM

3db882c

Add AES-CMAC and edit test vectors

6b4aab5

ttungle96 closed this Oct 14, 2025

Xaes 256 gcm #2740

Xaes 256 gcm #2740

Conversation

ttungle96 commented Oct 9, 2025

Issues:

Description of changes:

Call-outs:

Testing:

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

justsmth Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

ttungle96 Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 10, 2025

codecov-commenter commented Oct 9, 2025 •

edited

Loading