Skip to content

fix: Set requestTimeEpoch with ms precision (#8020) #8021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

HaaLeo
Copy link

@HaaLeo HaaLeo commented May 13, 2025

Which issue(s) does this change fix?

Fixes #8020

Why is this change necessary?

It's necessary to comply with the APIGateway context specification

How does it address the issue?

set the timestamp with ms resolution

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HaaLeo HaaLeo requested a review from a team as a code owner May 13, 2025 18:59
@github-actions github-actions bot added area/local/start-api sam local start-api command area/local/invoke sam local invoke command area/local/start-invoke pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels May 13, 2025
@HaaLeo
Copy link
Author

HaaLeo commented Jun 6, 2025

@roger-zhangg can we give this PR another try? I've updated it and it should be all good. However, the test coverage seems to fail on my local machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: sam local start-api sets context variable requestTimeEpoch with seconds precision instead of milliseconds
2 participants