Skip to content

feat(lib-storage): skip uploading parts if they are already listed in uploadedParts. #7211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(lib-storage): skip uploading parts if they are already listed in uploadedParts. #7211

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d51f12
feat(lib-storage): skip uploading parts if they are already listed in…
joy-yu Jul 17, 2025
f382db0
fix(lib-storage): adopt the suggested changes from the review
joy-yu Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/lib-storage/src/Upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@ export class Upload extends EventEmitter {
}
}

// If the part is already uploaded, skip it.
if (this.uploadedParts.some((uploadedPart) => uploadedPart.PartNumber === dataPart.partNumber)) {
continue;
}

const partSize: number = byteLength(dataPart.data) || 0;

const requestHandler = this.client.config.requestHandler;
Expand Down