Add integration tests for decorator, config and cache hook functionalities #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 8 8
Lines 270 270
=======================================
Hits 265 265
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Simon Marty <simon.marty0@gmail.com>
simonmarty
reviewed
Aug 4, 2025
|
|
||
| def put(self, obj): | ||
| self.put_calls += 1 | ||
| # Return modified copy without mutating original |
There was a problem hiding this comment.
What's the idea behind this?
There was a problem hiding this comment.
To keep track of how many times secrets are stored in the cache.
There was a problem hiding this comment.
Ok, but we're not making any assertions on this information. I'm not seeing this providing value in the test run.
ThirdEyeSqueegee
approved these changes
Aug 8, 2025
simonmarty
requested changes
Aug 18, 2025
|
|
||
| def put(self, obj): | ||
| self.put_calls += 1 | ||
| # Return modified copy without mutating original |
There was a problem hiding this comment.
Ok, but we're not making any assertions on this information. I'm not seeing this providing value in the test run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.