-
-
Notifications
You must be signed in to change notification settings - Fork 327
Add sqs handler #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add sqs handler #1377
Conversation
4296756
to
7c19bea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joseiedo, thanks for the PR, looks super good!
Left a couple of comments, please let me know if you have any questions about them.
Feel free to move ahead with it and please add yourself as an author in the new classes and the ones you changed.
Thanks!
.../main/java/io/awspring/cloud/sqs/listener/adapter/AbstractMethodInvokingListenerAdapter.java
Outdated
Show resolved
Hide resolved
...aws-sqs/src/main/java/io/awspring/cloud/sqs/listener/adapter/DelegatingInvocableHandler.java
Outdated
Show resolved
Hide resolved
Thanks, @tomazfernandes! I'll push the adjustments and add remanining documentation soon |
860e7f1
to
15799d4
Compare
Hey @tomazfernandes Please, let me know any improvements I could make! |
@joseiedo, thanks for the changes! Looks super good. Is there any other improvement you have in mind? I plan on doing a final review next weekend, and if there's nothing else we can merge it by then. |
Sounds good, @tomazfernandes! I don't have any improvements in mind at the moment, so I'll be waiting for your review. :) |
📢 Type of change
📜 Description
Add SqsHandler annotation
Update AbstractListenerAnnotationBeanPostProcessor, AbstractMethodInvokingListenerAdapter.java and its subclass to process methods annotated with SqsHandler
💡 Motivation and Context
Solves #1331
💚 How did you test it?
Adding unit tests and integration tests
Adding a new Sample
📝 Checklist
🔮 Next steps