Skip to content

Add sqs handler #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add sqs handler #1377

wants to merge 1 commit into from

Conversation

joseiedo
Copy link
Contributor

@joseiedo joseiedo commented May 3, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add SqsHandler annotation
Update AbstractListenerAnnotationBeanPostProcessor, AbstractMethodInvokingListenerAdapter.java and its subclass to process methods annotated with SqsHandler

💡 Motivation and Context

Solves #1331

💚 How did you test it?

Adding unit tests and integration tests
Adding a new Sample

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

  • Add documentation
  • Improve the implementation
  • Test more different cases

@github-actions github-actions bot added the component: sqs SQS integration related issue label May 3, 2025
@joseiedo joseiedo force-pushed the add-sqs-handler branch 3 times, most recently from 4296756 to 7c19bea Compare May 3, 2025 03:12
Copy link
Contributor

@tomazfernandes tomazfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joseiedo, thanks for the PR, looks super good!

Left a couple of comments, please let me know if you have any questions about them.

Feel free to move ahead with it and please add yourself as an author in the new classes and the ones you changed.

Thanks!

@joseiedo
Copy link
Contributor Author

joseiedo commented May 4, 2025

Thanks, @tomazfernandes! I'll push the adjustments and add remanining documentation soon

@joseiedo joseiedo force-pushed the add-sqs-handler branch from 0c0b5a8 to 503ac8d Compare May 7, 2025 02:29
@github-actions github-actions bot added the type: documentation Documentation or Samples related issue label May 7, 2025
@joseiedo joseiedo force-pushed the add-sqs-handler branch 5 times, most recently from 860e7f1 to 15799d4 Compare May 10, 2025 02:58
@joseiedo joseiedo marked this pull request as ready for review May 10, 2025 03:04
@joseiedo joseiedo requested a review from tomazfernandes May 10, 2025 03:04
@joseiedo
Copy link
Contributor Author

Hey @tomazfernandes
pushed some changes and added more docs + the sample

Please, let me know any improvements I could make!

@tomazfernandes
Copy link
Contributor

@joseiedo, thanks for the changes! Looks super good.

Is there any other improvement you have in mind?

I plan on doing a final review next weekend, and if there's nothing else we can merge it by then.

@joseiedo
Copy link
Contributor Author

Sounds good, @tomazfernandes! I don't have any improvements in mind at the moment, so I'll be waiting for your review. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sqs SQS integration related issue type: documentation Documentation or Samples related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants