feat(slave side prot): Add support for slave side mmio protection #260
+43
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelafsilva5
requested review from
DavidMCerdeira,
danielRep,
josecm and
sandro2pinto
as code owners
miguelafsilva5
force-pushed
the
feat/slave-side-prot
branch
from
c16ef38 to
3adf6ca
Compare
miguelafsilva5
force-pushed
the
ref/as
branch
from
ad97547 to
787ac35
Compare
miguelafsilva5
force-pushed
the
feat/slave-side-prot
branch
2 times, most recently
from
e99f0a2 to
65194e1
Compare
josecm
requested changes
Oct 24, 2025
miguelafsilva5
force-pushed
the
ref/as
branch
from
787ac35 to
9869e87
Compare
miguelafsilva5
force-pushed
the
feat/slave-side-prot
branch
3 times, most recently
from
a2a4944 to
e239802
Compare
Member
|
@miguelafsilva5 please resolve conflicts |
miguelafsilva5
force-pushed
the
feat/slave-side-prot
branch
3 times, most recently
from
7849408 to
b0a283a
Compare
Member
|
@miguelafsilva5 please resolve conflicts again. Ping me as soon as it is done so it doesn't happen again with other PRs accepted to main. |
miguelafsilva5
force-pushed
the
feat/slave-side-prot
branch
from
b0a283a to
4c261de
Compare
The mmio regions present in the platform description are to be mapped accessible for all address spaces. Signed-off-by: Miguel Silva <miguelafsilva5@gmail.com>
Each architecture needs to implement their access control function. This function is called during the dev init for vms, and is executed instead of the original memory mapping. Signed-off-by: Miguel Silva <miguelafsilva5@gmail.com>
Signed-off-by: Miguel Silva <miguelafsilva5@gmail.com>
miguelafsilva5
force-pushed
the
feat/slave-side-prot
branch
from
4c261de to
c2b9eff
Compare
Member
Author
@josecm should be fixed |
Member
|
@danielRep @DavidMCerdeira please review this PR |
josecm
approved these changes
Nov 13, 2025
Comment on lines
+207
to
+213
|
|
||
| ifeq ($(mmio_slave_side_prot),y) | ||
| build_macros+=-DMMIO_SLAVE_SIDE_PROT | ||
|
|
||
| ifneq ($(arch_mem_prot),mpu) | ||
| $(error mmio_slave_side_prot=y requires arch_mem_prot=mpu) | ||
| endif |
Member
There was a problem hiding this comment.
deleted by mistake?
ifeq ($(phys_irqs_only),y)
build_macros+=-DPHYS_IRQS_ONLY
josecm
reviewed
Nov 14, 2025
|
|
||
| cpu_sync_init(&vm->sync, vm->cpu_num); | ||
|
|
||
| vm_mem_prot_init(vm, vm_config); |
Member
There was a problem hiding this comment.
Also deleted by mistake? Why are we removing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR introduces support for slave-side MMIO protection. This is needed on MCU platforms that otherwise would require each device to be mapped in the MPU. With this PR, the entire MMIO region(s) is mapped on the MPU and each architecture/platform needs to implement a functions that enables and controls the access to each device. This function is called during vm device initialization.
It is important to note that, when installing an emul handler for a device inside the mmio region, if slave side mmio protection is enabled, we have to unmap the device memory range.
This PR was only tested for TC4, as it is the current platform that needs this feature. Before accepting the PR we have to make sure all other platforms are running as expected.