Run CI codestyle fixes on PRs rather than master #1634
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bump stefanzweifel/git-auto-commit-action to v5
jnoordsij
force-pushed
the
ci-codestyle-proposal
branch
from
7614704 to
0e44635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CI configuration tries to commit automatic style fixes to the
masterbranch. This fails due to pushing not being allowed due to branch protection rules; see e.g. https://github.com/barryvdh/laravel-debugbar/actions/runs/9922834440/job/27412338699#step:7:62.This PR moves the codestyle fixes to be applied on the individual PRs. Alternatively, the protection rules could be updated to ensure the GitHub actions bot is allowed to push to the
masterbranch.Edit: appearently the config suggested per https://github.com/stefanzweifel/git-auto-commit-action?tab=readme-ov-file#checkout-the-correct-branch does not seem to work yet with checking out; might investigate later.