Add changes from Erudite (basically rewrite test handling) #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackjohn7
reviewed
Aug 29, 2025
| question_idx: u32, | ||
| question_text: String, | ||
| test_results: TestResults, | ||
| // test_results: TestResults, |
There was a problem hiding this comment.
just putting this comment here so this isn't forgotten
|
I think this PR is finally ready, though it will break the current client, so those changes should probably be made before this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite test handling, taking advantage of the new Erudite architecture.
Tests will now work like this:
At server startup,
TestContexts will be built for each test environment (atm just each language, but will expand to workspaces, once implemented)To run a test/submission, a POST request should be set to
/questions/<id>/testsor/questions/<id>/submissions, this will return the id of the test and set theLocationheader to a location for polling.This will spawn the test suite. If the user has a websocket connected, they will receive live events when the individual tests finish (debounced).
The state of tests/submissions can be polled by sending a GET request to
/questions/<question-id>/tests/<test-id>or/questions/<question-id>/submissions/<submission-id>Additionally, tests can be cancelled by sending a DELETE request to
/questions/<question-id>/tests/<test-id>or/questions/<question-id>/submissions/<submission-id>