-
Notifications
You must be signed in to change notification settings - Fork 0
Rewrite the crate #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
funnyboy-roks
wants to merge
49
commits into
main
Choose a base branch
from
rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add additional data for the test cases (for things like visibility) - `Unset<X>` -> `Missing<X>` for slightly nicer error messages - Add `build_and_reset` and `build_and_consume` functions - Start implementation of test runner - Create necessary files - Compile code - Setup framework for running tests - Replace `anyhow` with `thiserror` - Add tracing for logs
This was
linked to
issues
Aug 19, 2025
f81c207
to
21307a1
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Love this so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a full rewrite of the crate, now that we've used it and noticed issues.
There are a few important points that I'm trying to accomplish with this rewrite that were missing from the original:
JoinSet
works, with ajoin_next
-equivalent function that will return the next finished test.This will also close #2, #6, and
#7.Major TODO items:
TestContext
Add serde derives where logicalMultiple Strings (? - Not sure if we need this on top of regex)Opting against this for now, we may want to re-evaluate at a later point in time.