Configure linters to project style #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds configuration files for the most common CMake linters, setting them up to ignore some of their default rules. I could see how changing the title to specifically refer to CMake could be appropriate. I have not made any attempts at working with e.g. the C++ files. Maybe additional setup is required to prevent ones editor to light up like a Christmas tree?
An alternative to merging this would of course be to adapt this project's style to follow best practices. In fact some lints ignored in this commit are related to indenting, which the existing open pull request #70 attempts to improve.
Ignoring the issue, thus requiring each and every potentially interested coder to maintain their own exceptions for the project, is seldom the greatest approach for attracting contributions.