Skip to content

Add prometheus/grafana metrics dashboard #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Add prometheus/grafana metrics dashboard #119

wants to merge 26 commits into from

Conversation

luca-medeiros
Copy link
Contributor

@luca-medeiros luca-medeiros commented Feb 15, 2024 •
edited
Loading

Closes #111

Progress

  • Infra + code -> loki, prom, grafana, tempo, multiproc prom, compose
  • Dashboard -> should check if metrics and titles match
  • Docs -> readme info on how to use, env

Luca Medeiros and others added 18 commits January 31, 2024 18:34
add new services to docker-compose
9ea0ab5
add new services to docker-compose
38cd3e2
merge
9966703
add init dashboard configs
5dfffad
fix container names
e3afafb
Merge remote-tracking branch 'upstream/main' into feat/111-metrics
f486491
add prometheus middleware
fab2607
update setup optl, prometheus
280e1e6
consistency
f6dd40d
add prometheus for gunicorn (multiprocess)
3668dd9
update logger for tracing
0ca00c4
add prometheus multiprocessing folder
845bf10
fix docker-compose for multiproc gunicorn
d4d2a77
add dependencies
da6d2c5
Squashed commit of the following:
9a05996 
commit b1a8370
Merge: ddec40e 169e93f
Author: Igor Benav <43156212+igorbenav@users.noreply.github.com>
Date:   Thu Feb 15 00:26:05 2024 -0300

    Merge pull request benavlabs#118 from luca-medeiros/fix/router

    bug: fix missing router when creating application

commit 169e93f
Author: Luca Medeiros <luca.medeiros@nuvi-labs.com>
Date:   Thu Feb 15 12:24:15 2024 +0900

    bug: fix missing router when creating application
add excluded handlers to prom
1cc2e0e
compose
294a871
@luca-medeiros
Merge branch 'main' into feat/111-metrics
32a5ae4
@igorbenav
Copy link
Collaborator

Hey, @luca-medeiros, do you still plan to finish this? I'm waiting to run some benchmarks

@luca-medeiros luca-medeiros changed the title [WIP] Add prometheus/grafana metrics dashboard Add prometheus/grafana metrics dashboard May 13, 2024
@luca-medeiros
Copy link
Contributor Author

@igorbenav would appreciate a review! Did some polishing today.

@twentyone24
Copy link

@luca-medeiros @igorbenav any updates over this :)

@QuanMofii
Copy link

@luca-medeiros @igorbenav still waiting :)

@luca-medeiros
Copy link
Contributor Author

If anyone wants to pull the branch and try, feel free.

@ninichuuh
Copy link

Hi.
@luca-medeiros do you mind if i take over and finish this pr?

@luca-medeiros
Copy link
Contributor Author

Sure
Would check if its still in the project roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twentyone24 twentyone24 twentyone24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prometheus/grafana metrics dashboard + (loki, tempo for logging)
5 participants
@luca-medeiros @igorbenav @twentyone24 @QuanMofii @ninichuuh