Skip to content

feat: sync Soul group 1 primitives #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

hunterbecton
Copy link
Contributor

@hunterbecton hunterbecton commented Apr 1, 2025

What/Why?

Syncs the following Soul primitives with Catalyst:

  • Accordion
  • Alert
  • AnimatedLink
  • Badge
  • Banner
  • BlogPostCard
  • Button
  • ButtonLink
  • Carousel
  • Chip

Syncs BlogPostList since the component is dependent on BlogPostCard

@hunterbecton hunterbecton requested a review from a team as a code owner April 1, 2025 22:27
Copy link

linear bot commented Apr 1, 2025

Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 2:41pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Apr 2, 2025 2:41pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 2:41pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 2:41pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 2:41pm

Copy link

changeset-bot bot commented Apr 1, 2025

⚠️ No Changeset found

Latest commit: e9d6065

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hunterbecton hunterbecton force-pushed the hunter/vib-4042-update-catalyst-with-vibes-primitives-group-1 branch from 4ebf819 to 1d2d5c4 Compare April 1, 2025 22:37
@hunterbecton hunterbecton force-pushed the hunter/vib-4042-update-catalyst-with-vibes-primitives-group-1 branch from 1d2d5c4 to c7d153f Compare April 1, 2025 22:38
@hunterbecton hunterbecton force-pushed the hunter/vib-4042-update-catalyst-with-vibes-primitives-group-1 branch from c7d153f to 284ff70 Compare April 2, 2025 14:30
@hunterbecton hunterbecton force-pushed the hunter/vib-4042-update-catalyst-with-vibes-primitives-group-1 branch from 284ff70 to 3e7144e Compare April 2, 2025 14:37
@hunterbecton hunterbecton force-pushed the hunter/vib-4042-update-catalyst-with-vibes-primitives-group-1 branch from 3e7144e to e9d6065 Compare April 2, 2025 14:40
Copy link
Contributor

github-actions bot commented Apr 2, 2025

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-canary-e0yaftifj-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 83
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 85

Copy link
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure there is are no conflicts with tailwind 4.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants