Skip to content

feat: syncs and adds support for button and button-link in site theme #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: integrations/makeswift
Choose a base branch
from

Conversation

hunterbecton
Copy link
Contributor

What/Why?

  • syncs Button and ButtonLink with Soul
  • renames Foreground to Text in Site Theme

Testing

CleanShot.2025-04-03.at.14.32.16.mp4

@hunterbecton hunterbecton requested a review from a team as a code owner April 3, 2025 18:33
Copy link

linear bot commented Apr 3, 2025

Copy link

changeset-bot bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: ce302f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 8:51pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Apr 3, 2025 8:51pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 8:51pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 8:51pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 8:51pm

@hunterbecton hunterbecton marked this pull request as draft April 3, 2025 20:34
Copy link
Contributor

github-actions bot commented Apr 3, 2025

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-canary-qxq09w3d8-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 92
🟠 Best practices 78
🟢 SEO 91

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 56
🟢 Accessibility 92
🟠 Best practices 78
🟢 SEO 90

Copy link
Collaborator

@migueloller migueloller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we please get a changeset with details on the change, what to expect, what to do to migrate, etc.?

@@ -17,6 +17,7 @@ export const SiteTheme = ({ fontTokens, ...theme }: TokensProps & ThemeProps) =>
${fontTokensToCssVars(fontTokens).join('\n')}
${themeToCssVars(theme).join('\n')}
--font-family-mono: var(--font-family-accent);
--button-primary-text: var(--button-primary-foreground);
Copy link

@pvaladez pvaladez Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change all the foreground prop names to text in core/lib/makeswift/components/site-theme/components/button.ts to avoid needing to declare a new --button-primary-text css variable here. We're already building the css variables from the Makeswift control values via themeToCssVars(), so I would prefer to see that functionality not overridden if we can avoid the extra complexity of doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants