fix: default slot QoL #2212

drewpledger · 2025-04-09T20:21:02Z

There is now a default slot that is used where conditions do not apply, or a user does not have a group id

Before, if a group was simulated that did not exist in the "Targeted customer groups" control, we would render a message saying that you need to add this group before it can render properly. However, I realized after documenting our instructions for this that this would present several issues when modifying your storefront customer groups.

If you add a customer group, and assign customers to that group, every customer would see the error div until the MS user changes every instance of this component.
There was no way to render what every other group would see.

This PR aims to address those potential issues:

CleanShot.2025-04-09.at.18.19.38.mp4

vercel · 2025-04-09T20:21:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
catalyst-canary	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 29, 2025 5:27pm

4 Skipped Deployments

Name	Status	Preview	Updated (UTC)
catalyst	⬜️ Ignored (Inspect)		Apr 29, 2025 5:27pm
catalyst-au	⬜️ Ignored (Inspect)	Visit Preview	Apr 29, 2025 5:27pm
catalyst-soul	⬜️ Ignored (Inspect)	Visit Preview	Apr 29, 2025 5:27pm
catalyst-uk	⬜️ Ignored (Inspect)	Visit Preview	Apr 29, 2025 5:27pm

changeset-bot · 2025-04-09T20:21:08Z

⚠️ No Changeset found

Latest commit: 5078d05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jamesqquick · 2025-04-14T14:06:03Z

core/lib/makeswift/components/customer-group-slot/customer-group-slot.makeswift.tsx

-  const actualSlot = allSlots?.find((s) => s.group === `${customerGroupId}`)?.slot ?? (
-    <UntargetedGroup />
-  );
+  const customerGroup = customerGroupId || DEFAULT_GROUP_ID;


Could you set the default to `DEFAULT_GROUP_ID1 in line 46 directly so you don't have to do it here?

jamesqquick · 2025-04-14T14:07:29Z

core/lib/makeswift/components/customer-group-slot/customer-group-slot.makeswift.tsx

-function CustomerGroupSlot({ className, slots, simulatedGroup = NO_GROUP_ID, noGroupSlot }: Props) {
-  const allSlots = slots?.concat({ group: NO_GROUP_ID, slot: noGroupSlot });
+function CustomerGroupSlot({ className, slots, simulatedGroup, defaultSlot }: Props) {
+  const targetedSlots = slots?.concat({ group: DEFAULT_GROUP_ID, slot: defaultSlot });
  const isInBuilder = useIsInBuilder();


Was there a decision made on if this function was something that was ok to use?

Yup, Miguel approved the usage

migueloller

@drewpledger, these changes look good to me. I thought we were planning on getting rid of this component due to some issues we found, though?

migueloller · 2025-04-21T21:17:54Z

core/lib/makeswift/components/customer-group-slot/customer-group-slot.makeswift.tsx

-                  }))
-                  .filter((option) => option.label.toLowerCase().includes(query.toLowerCase()));
+                return [
+                  { id: NO_GROUP_ID, label: 'No-group', value: NO_GROUP_ID },


Should the label be "No group", without the hyphen?

…s control

github-actions · 2025-04-29T17:30:31Z

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-canary-c3fta4b1f-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category	Score
🟢 Performance	99
🟢 Accessibility	92
🟠 Best practices	78
🟢 SEO	91

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category	Score
🟠 Performance	57
🟢 Accessibility	92
🟠 Best practices	78
🟢 SEO	90

drewpledger requested a review from a team as a code owner April 9, 2025 20:21

drewpledger requested review from migueloller and bookernath April 9, 2025 20:22

drewpledger force-pushed the dp/customer-groups-fix branch from 817c440 to 75305ba Compare April 9, 2025 20:28

vercel bot deployed to Preview – catalyst-canary April 9, 2025 20:30 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from 75305ba to 4e3b49a Compare April 9, 2025 20:30

vercel bot deployed to Preview – catalyst-canary April 9, 2025 20:32 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from 4e3b49a to 8c769d1 Compare April 9, 2025 20:48

vercel bot deployed to Preview – catalyst-canary April 9, 2025 20:49 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from 8c769d1 to ac549ea Compare April 9, 2025 21:07

vercel bot deployed to Preview – catalyst-canary April 9, 2025 21:09 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from ac549ea to c980cc5 Compare April 9, 2025 21:51

vercel bot deployed to Preview – catalyst-canary April 9, 2025 21:53 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from c980cc5 to 9545414 Compare April 9, 2025 22:01

vercel bot deployed to Preview – catalyst-canary April 9, 2025 22:02 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from 9545414 to 0151967 Compare April 9, 2025 22:18

vercel bot deployed to Preview – catalyst-canary April 9, 2025 22:20 View deployment

vercel bot deployed to Preview – catalyst-canary April 10, 2025 15:40 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from d232af6 to 36f67e8 Compare April 10, 2025 16:16

vercel bot deployed to Preview – catalyst-canary April 10, 2025 16:18 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from 36f67e8 to eaf8ec2 Compare April 11, 2025 16:06

vercel bot deployed to Preview – catalyst-canary April 11, 2025 16:07 View deployment

drewpledger changed the title ~~fix: default slot + no-group adjustments~~ fix: default slot QoL Apr 11, 2025

vercel bot deployed to Preview – catalyst-canary April 11, 2025 16:59 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from 4432749 to 616c78a Compare April 11, 2025 17:08

vercel bot deployed to Preview – catalyst-canary April 11, 2025 17:10 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from 616c78a to 2eaf036 Compare April 11, 2025 19:11

vercel bot deployed to Preview – catalyst-canary April 11, 2025 19:12 View deployment

jamesqquick reviewed Apr 14, 2025

View reviewed changes

drewpledger force-pushed the dp/customer-groups-fix branch 2 times, most recently from 2eaf036 to 585ee1c Compare April 14, 2025 21:26

vercel bot deployed to Preview – catalyst-canary April 14, 2025 21:28 View deployment

drewpledger requested a review from jamesqquick April 14, 2025 21:29

drewpledger force-pushed the dp/customer-groups-fix branch from 79bcaf3 to 87d22de Compare April 14, 2025 21:34

vercel bot deployed to Preview – catalyst-canary April 14, 2025 21:35 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from 87d22de to 3919a8b Compare April 14, 2025 21:38

vercel bot deployed to Preview – catalyst-canary April 14, 2025 21:40 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from 3919a8b to e5d8ec6 Compare April 14, 2025 21:40

vercel bot deployed to Preview – catalyst-canary April 14, 2025 21:42 View deployment

drewpledger force-pushed the dp/customer-groups-fix branch from e5d8ec6 to f420817 Compare April 16, 2025 20:01

vercel bot deployed to Preview – catalyst-canary April 16, 2025 20:03 View deployment

vercel bot deployed to Preview – catalyst-canary April 21, 2025 15:32 View deployment

migueloller reviewed Apr 21, 2025

View reviewed changes

fix: default group added, no-groups added to option of targeted group…

2b647d9

…s control

drewpledger force-pushed the dp/customer-groups-fix branch from fc89443 to 2b647d9 Compare April 28, 2025 19:25

vercel bot deployed to Preview – catalyst-canary April 28, 2025 19:27 View deployment

Merge branch 'integrations/makeswift' into dp/customer-groups-fix

5078d05

drewpledger requested a review from migueloller April 29, 2025 17:26

vercel bot deployed to Preview – catalyst-canary April 29, 2025 17:27 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: default slot QoL #2212

fix: default slot QoL #2212

Uh oh!

drewpledger commented Apr 9, 2025 •

edited

Loading

Uh oh!

vercel bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

jamesqquick Apr 14, 2025

Uh oh!

jamesqquick Apr 14, 2025

Uh oh!

drewpledger Apr 14, 2025

Uh oh!

migueloller left a comment

Uh oh!

migueloller Apr 21, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

Uh oh!

fix: default slot QoL #2212

Are you sure you want to change the base?

fix: default slot QoL #2212

Uh oh!

Conversation

drewpledger commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

jamesqquick Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

jamesqquick Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

drewpledger Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

migueloller left a comment

Choose a reason for hiding this comment

Uh oh!

migueloller Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 29, 2025

⚡️🏠 Lighthouse report

🖥️ Desktop

📱 Mobile

Uh oh!

Uh oh!

drewpledger commented Apr 9, 2025 •

edited

Loading

vercel bot commented Apr 9, 2025 •

edited

Loading

changeset-bot bot commented Apr 9, 2025 •

edited

Loading