-
Notifications
You must be signed in to change notification settings - Fork 289
chore: rename /vibes/soul/ to /ui/ #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a157ba4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
Thanks for the migration steps! |
a818ca1
to
e95d320
Compare
7cd16b0
to
6b828d6
Compare
6b828d6
to
a157ba4
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-canary-hzajnbm2p-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
/vibes/soul/
to /ui/
/vibes/soul/
to /ui/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for providing instructions. I still find some specifics missing, like how users actually get updates (is it via git pull upstream @bigcommerce/catalyst-core@rc.12
?) and what steps they could take to minimize conflicts.
What/Why?
Rename
/vibes/soul/
to/ui/
, replacing all imports and configuration rules to match new pathname.Testing
No eslint errors.
Migration instructions
Rebase conflicts
/vibes/soul/*
need to be moved to/ui/
.@/vibes/soul/
to@/ui/
.pnpm run lint -- --fix
to fix import order or fix manually.Manual migration
/vibes/soul/
for/ui/
.@/vibes/soul/
to@/ui/
.tsconfig.json
to point to the@/ui
path.next.config.ts
to replacesvibes
withui
in the included eslint dirs.global.css
to replace./vibes
with./ui
.pnpm run lint -- --fix
to auto fix import order.