You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR should only be merged after we merge #2334
This PR builds on #2334 by adding the integrations/makeswift branch to the list of workflow triggers for the changesets-release.yml GitHub Action.
When merged, the code in this PR will immediately trigger a new run of the changesets-release.yml GitHub Action; this will update the existing Version Packages PR (#1892) title from Version Packages to Version Packages (canary). Since the workflow trigger has been expanded with the integrations/makeswift branch, the next time the integrations/makeswift branch is pushed to, it will create another PR called Versions Packages (integrations/makeswift).
Release Day
When we are ready to release @bigcommerce/catalyst-core@1.0.0 and @bigcommerce/catalyst-makeswift@1.0.0, we should follow the steps below:
Ensure that a major version bump changeset exists for core/ (done), packages/client, packages/create-catalyst, and packages/eslint-config-catalyst
Merge Version Packages (main)
🚀 This will release @bigcommerce/catalyst-core@1.0.0, @bigcommerce/create-catalyst@1.0.0, @bigcommerce/catalyst-client@1.0.0, and @bigcommerce/eslint-config-catalyst@1.0.0
Merge branch canary into integrations/makeswift
a. Ensure you do not overwrite the CHANGELOG.md with the CHANGELOG.md from canary
b. Ensure you do not overwrite core/package.json fields for name or version on integrations/makeswift from canary
After the merge commit, run pnpm changeset on integrations/makeswift to create a new major release for @bigcommerce/catalyst-makeswift. Link to the appropriate 1.0.0 entry in the canary changelog.
Once merged, a PR called `Version Packages (integrations/makeswift) should be created
Merge Version Packages (integrations/makeswift)
🚀 This will release @bigcommerce/catalyst-makeswift@1.0.0
Step 4 above should probably be automated, and we should also see if we can automate a PR to merge canary into integrations/makeswift whenever we merge a Version Packages (main) PR.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matthewvolk
force-pushed
the
CATALYST-1272-prep-release
branch
from
What/Why?
Warning
This PR should only be merged after we merge #2334
This PR builds on #2334 by adding the
integrations/makeswiftbranch to the list of workflow triggers for thechangesets-release.ymlGitHub Action.When merged, the code in this PR will immediately trigger a new run of the
changesets-release.ymlGitHub Action; this will update the existingVersion PackagesPR (#1892) title fromVersion PackagestoVersion Packages (canary). Since the workflow trigger has been expanded with theintegrations/makeswiftbranch, the next time theintegrations/makeswiftbranch is pushed to, it will create another PR calledVersions Packages (integrations/makeswift).Release Day
When we are ready to release
@bigcommerce/catalyst-core@1.0.0and@bigcommerce/catalyst-makeswift@1.0.0, we should follow the steps below:core/(done),packages/client,packages/create-catalyst, andpackages/eslint-config-catalystVersion Packages (main)@bigcommerce/catalyst-core@1.0.0,@bigcommerce/create-catalyst@1.0.0,@bigcommerce/catalyst-client@1.0.0, and@bigcommerce/eslint-config-catalyst@1.0.0canaryintointegrations/makeswifta. Ensure you do not overwrite the
CHANGELOG.mdwith theCHANGELOG.mdfromcanaryb. Ensure you do not overwrite
core/package.jsonfields fornameorversiononintegrations/makeswiftfromcanarypnpm changesetonintegrations/makeswiftto create a new major release for@bigcommerce/catalyst-makeswift. Link to the appropriate 1.0.0 entry in thecanarychangelog.Version Packages (integrations/makeswift)@bigcommerce/catalyst-makeswift@1.0.0Step 4 above should probably be automated, and we should also see if we can automate a PR to merge
canaryintointegrations/makeswiftwhenever we merge aVersion Packages (main)PR.Testing
The changes and steps documented in this PR have been tested in the following playground repository:
https://github.com/matthewvolk/changesets-across-branches
Migration
N/A