feat: Add support for Buyer Portal in Catalyst #2404
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an onSubmit listener and move most of the logic outside the product-details-form component. The ideal solution here is to patch the form action at the root of the component tree, but that's proven complicated at this point. Will try to amend it in the future.
* feat: Add support for Buyer Portal in Catalyst * refactor: remove unnecessary useState/useEffects + simplify useB2B* logic * refactor: simplify use of env. variables * refactor: Simplify integration points with product-details-form Use an onSubmit listener and move most of the logic outside the product-details-form component. The ideal solution here is to patch the form action at the root of the component tree, but that's proven complicated at this point. Will try to amend it in the future. * fix: cart sync * fix: deprecating sync-cart * feat: Add support for Buyer Portal in Catalyst * refactor: remove unnecessary useState/useEffects + simplify useB2B* logic * refactor: simplify use of env. variables * refactor: Simplify integration points with product-details-form Use an onSubmit listener and move most of the logic outside the product-details-form component. The ideal solution here is to patch the form action at the root of the component tree, but that's proven complicated at this point. Will try to amend it in the future. * fix: changes according to review * fix: changes according to review * fix: improving cartId prop type --------- Co-authored-by: Ignacio Catalina <ignacio.catalina@bigcommerce.com>
🦋 Changeset detectedLatest commit: 0d11b87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Comment on lines
+321
to
+327
| CredentialsProvider({ | ||
| id: 'anonymous', | ||
| credentials: { | ||
| cartId: { type: 'text' }, | ||
| }, | ||
| authorize: loginWithAnonymous, | ||
| }), |
There was a problem hiding this comment.
Probably want to give this another rebase as we moved the anonymous session into its own cookie instead of reusing the next-auth one. This is to account for persistent cart to work correctly. See these PRs:
There was a problem hiding this comment.
another rebase given, can you have a look 🙇
There was a problem hiding this comment.
You shouldn't need this CredentialsProvider if you've pull in the code from those 3 PRs.
vercel
bot
temporarily deployed
to
Preview – functional_test_tteag7agni_1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration/b2b-buyer-portalWhat/Why?
Testing
Migration