Feat/ppcp ideal polling #2849
Open
Feat/ppcp ideal polling #2849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
andriiVitvitskyi1990
force-pushed
the
feat/ppcp_ideal_polling
branch
2 times, most recently
from
e60d793 to
d21cd19
Compare
andriiVitvitskyi1990
force-pushed
the
feat/ppcp_ideal_polling
branch
from
d21cd19 to
5ab4a87
Compare
bc-nick
reviewed
Jun 12, 2025
| gatewayId?: string, | ||
| ): Promise<void> { | ||
| await new Promise<void>((resolve, reject) => { | ||
| const timeout = setTimeout(resolve, this.pollingInterval); |
There was a problem hiding this comment.
Can you explain why you are using setTimeout here pls. From my vision it is redundant, but maybe I do not see the real reason
There was a problem hiding this comment.
This timeout needed to tick polling mechanism every n seconds
There was a problem hiding this comment.
It is still not clear for me. Looks like this timeout is working for nothing. You call resolve when time runs out for what?
bc-nick
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added PPCP APM Ideal polling mechanism
Why?
To properly handle order status
Testing / Proof
Screen.Recording.2025-06-11.at.10.45.33.mov
@bigcommerce/team-checkout @bigcommerce/team-payments