Feat/added ppcp fastlane 3ds #2884
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
andriiVitvitskyi1990
force-pushed
the
feat/added_ppcp_fastlane_3ds
branch
from
865e7db to
1f7ad64
Compare
andriiVitvitskyi1990
force-pushed
the
feat/added_ppcp_fastlane_3ds
branch
from
1f7ad64 to
770cc5e
Compare
…feat/added_ppcp_fastlane_3ds
andriiVitvitskyi1990
force-pushed
the
feat/added_ppcp_fastlane_3ds
branch
4 times, most recently
from
e105db3 to
2e1e933
Compare
andriiVitvitskyi1990
force-pushed
the
feat/added_ppcp_fastlane_3ds
branch
5 times, most recently
from
affa546 to
417cc02
Compare
bc-nick
reviewed
Jun 12, 2025
| } | ||
|
|
||
| if (authenticationState === 'canceled') { | ||
| console.log('3DS check was canceled'); |
There was a problem hiding this comment.
console.error might be better
| Fastlane(options?: PayPalFastlaneOptions): Promise<PayPalFastlane>; | ||
| } | ||
|
|
||
| interface ThreeDomainSecureClientShowResponse { | ||
| liabilityShift: string; | ||
| authenticationState: string; |
There was a problem hiding this comment.
Would be better to set enum type up here with available states instead of string. The same action for liabilityShift and use these enums where needed
andriiVitvitskyi1990
force-pushed
the
feat/added_ppcp_fastlane_3ds
branch
2 times, most recently
from
654ebbb to
b5a742e
Compare
andriiVitvitskyi1990
force-pushed
the
feat/added_ppcp_fastlane_3ds
branch
from
b5a742e to
8370b7a
Compare
andriiVitvitskyi1990
force-pushed
the
feat/added_ppcp_fastlane_3ds
branch
from
8370b7a to
2d8d886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added 3ds check for PPCP FL
Why?
To be able to check PPCP FL payment flow with 3DS validation
Testing / Proof
Screen.Recording.2025-06-11.at.15.32.11.mov
Screen.Recording.2025-06-11.at.15.29.29.mov
@bigcommerce/team-checkout @bigcommerce/team-payments