feat(payment): PI-4031 Change how payment_method_category parameter i… #2890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-sebastianszafraniec
changed the title
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
bc-sebastianszafraniec
changed the title
bc-sebastianszafraniec
changed the title
bc-sebastianszafraniec
changed the title
bc-sebastianszafraniec
force-pushed
the
PI-4031
branch
3 times, most recently
from
356a420 to
c92122e
Compare
PavlenkoM
approved these changes
Jun 6, 2025
…s passed to Klarna
bc-sebastianszafraniec
force-pushed
the
PI-4031
branch
from
c92122e to
9920190
Compare
PavlenkoM
reviewed
Jun 12, 2025
| @@ -105,7 +105,7 @@ export default class KlarnaV2PaymentStrategy { | |||
|
|
|||
| await this.klarnav2TokenUpdater.klarnaOrderInitialization(cartId, clientToken); | |||
|
|
|||
| const { authorization_token: authorizationToken } = await this.authorizeOrThrow(methodId); | |||
| const { authorization_token: authorizationToken } = await this.authorizeOrThrow(methodId, gatewayId); | |||
There was a problem hiding this comment.
Suggested change
| const { authorization_token: authorizationToken } = await this.authorizeOrThrow(methodId, gatewayId); | |
| const paymentMethodСategory = this.isKlarnaSingleRadioButtonEnabled() ? gatewayId : methodId; | |
| const { authorization_token: authorizationToken } = await this.authorizeOrThrow(paymentMethodСategory); |
| @@ -228,7 +228,7 @@ export default class KlarnaV2PaymentStrategy { | |||
| return klarnaAddress; | |||
| } | |||
|
|
|||
| private async authorizeOrThrow(methodId: string): Promise<KlarnaAuthorizationResponse> { | |||
| private async authorizeOrThrow(methodId: string, gatewayId: string): Promise<KlarnaAuthorizationResponse> { | |||
There was a problem hiding this comment.
Suggested change
| private async authorizeOrThrow(methodId: string, gatewayId: string): Promise<KlarnaAuthorizationResponse> { | |
| private async authorizeOrThrow(paymentMethodСategory: string): Promise<KlarnaAuthorizationResponse> { |
| @@ -245,7 +245,7 @@ export default class KlarnaV2PaymentStrategy { | |||
| } | |||
|
|
|||
| this.klarnaPayments.authorize( | |||
| { payment_method_category: methodId }, | |||
| { payment_method_category: this.isKlarnaSingleRadioButtonEnabled() ? gatewayId : methodId }, | |||
There was a problem hiding this comment.
Suggested change
| { payment_method_category: this.isKlarnaSingleRadioButtonEnabled() ? gatewayId : methodId }, | |
| { payment_method_category: paymentMethodСategory }, |
…s passed to Klarna
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s passed to Klarna
What?
Adjusting payment_method_category to the new requirements requested by Klarna.
BE part - https://github.com/bigcommerce/bigpay/pull/9155
Also improved test coverage to meet 80% requirement
Testing / Proof
Tested manually
Klarna.mov
@bigcommerce/team-checkout @bigcommerce/team-payments