Import Url, not undefined URL #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I was trying to use the
getImageSrcsethelper on the frontend within a vue application. It wasn't working because the helper always thought the url was invalid. After investigating, I found that the.URLproperty does not exist on theurlmodule. I am not sure how this was working at all, but I changed the import to.Urlbecause that is the proper key for the module.After making this change, everything worked as expected.
How was it tested?
After making the change, the import worked correctly. I am using this on the frontend, so you would have to confirm it doesn't cause any issues within stencil. I can't imagine it would. Maybe the server does some sort of automatic case-insensitive search for the key, which is why the issue went unnoticed until I tried to use it on the frontend.
cc @bigcommerce/storefront-team