Skip to content

FIX: Remove on active job to true in getConcurrentJobs #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX: Remove on active job to true in getConcurrentJobs #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions Models/Queue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,6 @@ export class Queue {
// See: https://stackoverflow.com/questions/47359368/does-realm-support-select-for-update-style-read-locking/47363356#comment81772710_47363356
const concurrentJobIds = jobsToMarkActive.map( job => job.id);

// Mark concurrent jobs as active
jobsToMarkActive = jobsToMarkActive.map( job => {
job.active = true;
});

// Reselect now-active concurrent jobs by id.
const reselectQuery = concurrentJobIds.map( jobId => 'id == "' + jobId + '"').join(' OR ');
const reselectedJobs = this.realm.objects('Job')
Expand Down Expand Up @@ -371,9 +366,6 @@ export class Queue {

job.data = JSON.stringify(jobData);

// Reset active status
job.active = false;

// Mark job as failed if too many attempts
if (jobData.failedAttempts >= jobData.attempts) {
job.failed = new Date();
Expand Down