Fix C++23 compilation errors in leveldb #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2025 11:58
Remove usages of std::aligned_storage, which is deprecated. More details about the replacement in https://crbug.com/388068052. PiperOrigin-RevId: 713346733
cl/713346733 changed the type of some variables to pointers, but didn't adjust the placement new statements. From pkasting@: "I suspect your code is wrong and will crash. An array is a pointer, so taking its address also gives a pointer, which is why it compiles; but the value of that pointer is different. You're no longer providing the address of the storage, but rather the address of the array pointer." PiperOrigin-RevId: 717926210
|
FYI the upstream PR landed |
|
Chromium has also re-rolled to the current upstream: https://issues.chromium.org/issues/388068052#comment10. |
Undraft then? |
|
utACK 183e79a |
|
ACK 183e79a. I don't think the second commit actually changes anything. |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 7, 2025
4188247086 Merge bitcoin-core/leveldb-subtree#47: Fix C++23 compilation errors in leveldb 183e79a495 Fix speculatively some "placement new" issues in leveldb 82c31046ed Fix C++23 compilation errors in leveldb git-subtree-dir: src/leveldb git-subtree-split: 41882470862df219f74cdd38354007b91eb98191
Why? |
|
I tried it in godbolt, and both versions produce the same machine code (but also, my understanding of how arrays work in C++ is that there is no distinction). |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 17, 2025
4188247086 Merge bitcoin-core/leveldb-subtree#47: Fix C++23 compilation errors in leveldb 183e79a495 Fix speculatively some "placement new" issues in leveldb 82c31046ed Fix C++23 compilation errors in leveldb git-subtree-dir: src/leveldb git-subtree-split: 41882470862df219f74cdd38354007b91eb98191
l0rinc
pushed a commit
to l0rinc/bitcoin
that referenced
this pull request
Mar 19, 2025
4188247086 Merge bitcoin-core/leveldb-subtree#47: Fix C++23 compilation errors in leveldb 183e79a495 Fix speculatively some "placement new" issues in leveldb 82c31046ed Fix C++23 compilation errors in leveldb git-subtree-dir: src/leveldb git-subtree-split: 41882470862df219f74cdd38354007b91eb98191
sr-gi
pushed a commit
to sr-gi/bitcoin
that referenced
this pull request
Mar 20, 2025
4188247086 Merge bitcoin-core/leveldb-subtree#47: Fix C++23 compilation errors in leveldb 183e79a495 Fix speculatively some "placement new" issues in leveldb 82c31046ed Fix C++23 compilation errors in leveldb git-subtree-dir: src/leveldb git-subtree-split: 41882470862df219f74cdd38354007b91eb98191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks two commits from upstream (google@302786e, google@e829478), which remove the usage of
std::aligned_storage/std::aligned_union.Note the first cherry-pick is not clean, because due to Google tooling issues, it accidently contained a revert of the prior two commits. See google#1249 for more details, as well as https://issues.chromium.org/issues/388068052.
Closes #43.