Skip to content

wip: issue-320 #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

wip: issue-320 #331

merged 2 commits into from
Nov 4, 2025

Conversation

@reez
Copy link
Collaborator

@reez reez commented Nov 3, 2025 •
edited
Loading

Description

WIP: To address #320

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • UI changes tested on small, medium, and large devices to ensure layout consistency

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez linked an issue Nov 3, 2025 that may be closed by this pull request
Rejected transaction patch when FFI 2.0.1 or 2.1.0 is released #320
Closed
@reez reez mentioned this pull request Nov 3, 2025
Closed
rustaceanrob
rustaceanrob reviewed Nov 4, 2025
View reviewed changes
@rustaceanrob
Copy link
Contributor

rustaceanrob commented Nov 4, 2025

Approach looks good. Just one comment.

@rustaceanrob
Copy link
Contributor

rustaceanrob commented Nov 4, 2025

ACK 8f0f18e

LGTM. Maybe want to squash the wip commit.

@reez
Copy link
Collaborator Author

reez commented Nov 4, 2025 •
edited
Loading

ACK 8f0f18e

LGTM. Maybe want to squash the wip commit.

def, always squash+merge. thanks for reviewing 👍

@reez reez marked this pull request as ready for review November 4, 2025 17:21
@reez reez merged commit 99fb8c9 into bitcoindevkit:main Nov 4, 2025
1 check passed
@reez reez deleted the issue-321 branch November 4, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rustaceanrob rustaceanrob rustaceanrob left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rejected transaction patch when FFI 2.0.1 or 2.1.0 is released

2 participants

@reez @rustaceanrob