fix: Handle case-insensitive headers in multipart binary upload endpoint #17
+153
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantyk
commented
Oct 29, 2025
| Map<String, String> caseInsensitiveResponseHeaders = new TreeMap<>(String.CASE_INSENSITIVE_ORDER); | ||
| caseInsensitiveResponseHeaders.putAll(responseHeaders); | ||
|
|
||
| return Optional.ofNullable(caseInsensitiveResponseHeaders.get(HttpHeaders.LOCATION)).orElseThrow(() -> new IntegrationException("Could not find Location header.")); |
Author
There was a problem hiding this comment.
This ensures the keys are case insensitive but the values are still case sensitive. (A test should be added)
shantyk
changed the title
zahidblackduck
changed the title
zahidblackduck
requested review from
ChomickiM,
DanaMaxfield,
bd-samratmuk,
devmehtabd and
dterrybd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
IDETECT-4897
Description
Fixed case-sensitivity issue in
startMultipartUpload()method inFileUploaderclass where theLocationheader lookup was failing when proxies (e.g.mitmproxy) returned lowercase header names.startMultipartUpload()method to useTreeMap<>(String.CASE_INSENSITIVE_ORDER)for header retrieval, ensuring case-insensitive key matching while preserving case-sensitive valuesFileUploaderHeaderTestclass which covers the following:Locationheader error handling