BLENDER: contributor agreement support #15
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provider authored by Matti Ranta and Arnd Marijnissen.
Patch taken from issue number 17715, associating the LFS pointer when the file is downloaded.
To avoid accidentally spamming hundreds of people.
Both are off by default. This is implemented fully on the frontend, so all issues and their details are still always loaded.
Otherwise for some browsers, users have to login again for every session.
For Blender ID hook to do this.
…repos https://projects.blender.org/infrastructure/blender-projects-platform/issues/61 And add trace log for investigation.
To be used for RestructuredText rendering using Sphinx to HTML. See: https://projects.blender.org/infrastructure/gitea-custom/src/branch/main/sphinx#deployment
Don't escalate any errors, only log them, to avoid breaking sign-in.
Spam reporting is available for trusted users (org members and admins) via a button on a spammer's profile page; a new section Site Administration > Identity & Access > Spam Reports; a new "pending spam reports" indicator in the header for admins.
When viewing a file that the user can't edit because they can't write to the branch, the new, upload, patch, edit and delete functionality is no no longer disabled. If no user fork of the repository exists, there is now a page to create one. It will automatically create a fork with a single branch matching the one being viewed, and a unique repository name will be automatically picked. When a fork exists, but it's archived, a mirror or the user can't write code to it, there will instead be a missing explaining the situation. If the fork exists, a message will appear at the top of the edit page explaining that the changes will be applied to a branch in the fork. The base repository branch will be pushed to a new branch to the fork, and then the edits will be applied on top. The suggestion to fork happens when accessing /_edit/, so that for example online documentation can have an "edit this page" link to the base repository that does the right thing.
New models ContributorAgreement and SignedContributorAgreement are introduced.
A new Settings > Contributor Agreements page is introduced.
The page allows a user to review the text of existing contributor agreements
and to sign any of them.
A new /api/v1/users/{username}/contributor-agreements/{slug} endpoint allows to
check if a user has signed a contributor agreement.
This api endpoint can be used by a gitea action workflow, e.g. like this:
```
name: contributor agreement check
on:
pull_request_target:
types: [opened, ready_for_review, reopened, review_requested]
env:
CONTRIBUTOR_AGREEMENT: ...
jobs:
check_api:
runs-on: ...
steps:
- run: echo "Checking $CONTRIBUTOR_AGREEMENT for ${{ gitea.event.pull_request.user.login }}"
- run: result=$(curl --show-error --silent "$GITHUB_API_URL/users/${{ gitea.event.pull_request.user.login }}/contributor-agreements/$CONTRIBUTOR_AGREEMENT"); if [ "$result" == "OK" ]; then exit 0; else echo $result; exit 1; fi
```
|
Some screenshots of the UI would be nice for review. |
|
Here is a demonstration of the user-facing UI:
I'm open to any arguments on why and how this should be extended, since I was mostly aiming at a fully functioning but minimalistic implementation to save time in the initial development phase. |
bartvdbraak
approved these changes
Oct 3, 2025
brechtvl
approved these changes
Oct 3, 2025
blender-it
force-pushed
the
apply-patches-v1.24.3
branch
from
fd75124 to
745899b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New models ContributorAgreement and SignedContributorAgreement are introduced.
A new Settings > Contributor Agreements page is introduced. The page allows a user to review the text of existing contributor agreements and to sign any of them.
A new /api/v1/users/{username}/contributor-agreements/{slug} endpoint allows to check if a user has signed a contributor agreement. This api endpoint can be used by a gitea action workflow, e.g. like this:
https://projects.blender.org/Oleg-Komarov/clacheck-runner/src/branch/main/example.workflow.yml