Merge the new WinUI version into the main branch #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed naming of TitleBar.png for different scaling factors
Added layering to TitleBar background
Now using AppWindow.TitleBar which hopefully should work better
Misc simplification / cleanup
Moved them into each page, put all logic for their sizing in their respective classes. Changed the design of MainPage a bit.
Mostly the subtle border around buttons and the card style of the folder list
Various small fixes / simplifications
Only doing 30s right now, haven't tied it into the main page setting.
Also stores them between loads
Adjusted list padding further
Fixed inconsistent button sizes in the slide page titlebar Fixed error when loading files from folders that are inaccessable or junctions that can cause infinite loops Hopefully fixed some crashes with the image drawing component Updated to .NET 9 / C# 13
Now instantly adds folder, updates count once that's done TODO: show visual indicator of it loading, and disable refreshing the count until it's done
Added loading animation for the image counts Random code simplifications
Now the column definition widths are just bound to a single value in MainPage, no more looping every grid
Separated the listview into its own control. Use Utilities only as namespace now, moved existing utilities into MonitorInfo class
Some messy stuff to work around quirks of the list view drag and drop reordering (please fix MSFT).
Removed some whitespace
Made publish profiles no longer self contained. May reevaluate when publishing.
Fixed timing issues with the progress bar.
Fixed issue where setting writes were overlapping Fixed the left inset in the main page titlebar Disabled virtualization on the ListView to prevent inconsistent behaviour Completely changed how column width changes are detected / applied (old method was getting messed up with the refreshes)
It's now just enough to let the user see the loading animation to indicate something actually happened
Created the services and scaffolding for the basic architecture. TODO: Create ViewModels for every view to separate concerns. Moved core models to separate project. In the process of switching to SyncFusion Data Grid for folder list (currently displaying both versions in the main view so I have a reference for styling). Moved to .net10
Updated package versions (at least those that are compatible with each other) Removed explicit stream.Dispose calls in SettingsService (the using statement will do that at the end of the scope) Fixed publishing profiles on other platforms. Removed setter from path property in ImageFolder Added default parameter values for imageCount and selected in ImageFolder constructor Indicated intention to switch from locks to semaphore in SlidePage view
Updated code to load the new license from the new location
Still need to move the actual logic controlling the actual system window titlebar (not just the control)
MainPage and the new folder list view now display data from the ViewModel, but no real logic, and not all commands functioning SlideViewModel currently only exists to make navigation work, no functionality or set up for bindings yet Added Puased property on new SlideTitlebarControl (controls the play/pause button icon) Switched to the new titlebar on SlidePage (again, still not fully functional)
Titlebars now have their insets set correctly, and set the system titlebar to the right height/icon settings Implemented TitlebarService (not fully yet). The two titlebar controls now inheret a common class for functionality. The 2 main pages now inheret from a class with some built in common toolbar functionality. Added a DependencyProperty source generator, cutting down on a lot of boilerplate. Removed old initial frame navigation (that was breaking certain services, and really never should have still been there)
Removed some old navigation code
Added parameters to GoBack in INavigationService for navigation animation info
Slide page still needs to hook up all the buttons to commands Removed files for old toolbars Inactivity styling now also applies to the titlebar on the Slide page
Drag regions were completely broke on high dpi settings Insets weren't being set on the pages properly Moved SizeChanged binding for toolbars from the xaml to the base titlebar class
TODO: add back the functionality of opening explorer to file when clicking on the current image GetImages -> GetImagesForFolders, GetFolderImages -> GetImagesForFolder in ImageFolderList Removed SlidePaths from settings, moved to new service ISlideImageService Removed old SlidePage view
mostly to avoid dispose issues
Cleaned up some small things
Some minor handler renaming
(prevents the timer starting when losing the device, causing unwanted unpauses)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready yet.