Scope WaitGroup to subtests in memory cache tests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharing one WaitGroup across parallel subtests caused races and flaky tests. Declare wg locally in each t.Run so each subtest has its own sync.WaitGroup. - Remove shared wg at top of TestMemoryCache_ConcurrentAccess - Add var wg sync.WaitGroup inside Concurrent writes, Concurrent reads and writes, and Concurrent deletes subtests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Sharing one WaitGroup across parallel subtests caused races and flaky tests. Declare wg locally in each t.Run so each subtest has its own sync.WaitGroup.