feat: tag sd* drives as ephemeral also #363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Jan 29, 2025
| # - EC2 instance types with instance storage volumes | ||
| # - KVM VMs with additional virtio disks | ||
| KERNEL!="nvme*|vd*", GOTO="ephemeral_storage_end" | ||
| KERNEL!="nvme*|vd*|sd*", GOTO="ephemeral_storage_end" |
There was a problem hiding this comment.
To create symlinks under /dev/disk/ephemeral for the non-system disks, you'd also need a rule like this after the nvme* and vd* ones below:
# Create symlinks for any matching SCSI devices.
KERNEL=="sd*", \
SYMLINK+="disk/ephemeral/virtio-$env{ID_SERIAL}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #4370
Description of changes:
Minor change, adding the
sd*pattern to the allowlist of disks to be tagged by theghostdogutility.Testing done:
Mirrored these two rules in one custom rule, packaged it in our custom image, installed it on a system with
sd*disks and saw them tagged.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.