BM-1754: Zeroecco/stuck jobs #1247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Austin Abell <austinabell8@gmail.com>
…ess into zeroecco/stuck_jobs
zeroecco
requested review from
a team,
Wollac,
austinabell,
capossele,
ec2 and
willemolding
as code owners
|
🚀 Documentation Preview Deployment URL: https://boundless-documentation-ewy8i9uck-boundless-network.vercel.app Updated at: 2025-10-21 21:23:10 UTC |
willpote
reviewed
Oct 22, 2025
| const chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789'; | ||
| let result = ''; | ||
| for (let i = 0; i < 32; i++) { | ||
| result += chars.charAt(Math.floor(Math.random() * chars.length)); |
There was a problem hiding this comment.
Not the best practice to use a pseudorandom number generator for keys. Can we just set the API key in Pulumi state and pass it in (as we do in our other stacks for secrets), or use something like crypto.getRandomValues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the api layer for authenticated queries