Skip to content

BM-1765: mine by default, opt out with env #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

BM-1765: mine by default, opt out with env #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bae6e65
mine by default, opt out with env
austinabell Oct 22, 2025
812ec45
update to just prover command
austinabell Oct 22, 2025
2163395
always take down mining on prover down/clean
austinabell Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ services:
environment:
<<: *base-environment
RUST_LOG: ${RUST_LOG:-info}
entrypoint: /bin/bash -c "while sleep 1; do /app/bento_cli --iter-count 2000000; done"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we want this value as low as possible correct? What risks do we add or trade-off when lowering it?

Separately would it make sense to set this dynamically (via the wizard) based on cluster size?

Copy link
Contributor Author

@austinabell austinabell Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What risks do we add or trade-off when lowering it?

  • If running a lot of GPUs, the prove rate will be lower with smaller jobs (smaller effect for smaller provers)
  • Less efficient for minio storage of completed proofs
  • More proofs to roll up when doing povw prepare

Hard to pick a default that works for all systems, but this is just a guess at what most provers would find unoffensive. Perhaps something configurable with the config wizard, but unsure it's worth configuring until we know what proof sizes provers prefer.

entrypoint: /bin/bash -c "while sleep 1; do /app/bento_cli --iter-count 500000; done"

volumes:
redis-data:
Expand Down
53 changes: 22 additions & 31 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,48 +415,39 @@ bento action="up" env_file="" compose_flags="" detached="true":
exit 1
fi

# Run the broker service with a bento cluster for proving.
broker action="up" env_file="" detached="true":
# Run all components of a boundless prover (bento, broker, miner)
# Set BOUNDLESS_MINING=false to disable mining (e.g., BOUNDLESS_MINING=false just prover)
prover action="up" env_file="" detached="true":
#!/usr/bin/env bash
BOUNDLESS_MINING="${BOUNDLESS_MINING:-true}"

# Check if broker.toml exists, if not create it from template
if [ ! -f broker.toml ]; then
echo "Creating broker.toml from template..."
cp broker-template.toml broker.toml || { echo "Error: broker-template.toml not found"; exit 1; }
echo "broker.toml created successfully."
fi

just bento "{{action}}" "{{env_file}}" "--profile broker" "{{detached}}"

# Run the mining service with a bento cluster
mine action="up":
#!/usr/bin/env bash
if ! command -v docker &> /dev/null; then
echo "Error: Docker command is not available. Please make sure you have docker in your PATH."
exit 1
if [ "{{action}}" = "logs" ]; then
# Ignore mining process logs by default
PROFILE_FLAGS="--profile broker"
elif [ "{{action}}" = "down" ] || [ "{{action}}" = "clean" ]; then
# Always include miner profile when shutting down to ensure no lingering mining process
PROFILE_FLAGS="--profile broker --profile miner"
elif [ "$BOUNDLESS_MINING" = "false" ]; then
PROFILE_FLAGS="--profile broker"
else
PROFILE_FLAGS="--profile broker --profile miner"
fi

if ! docker compose version &> /dev/null; then
echo "Error: Docker compose command is not available. Please make sure you have docker in your PATH."
exit 1
fi
just bento "{{action}}" "{{env_file}}" "$PROFILE_FLAGS" "{{detached}}"

if [ "{{action}}" = "up" ]; then
echo "Starting mining service"
docker compose --profile miner up -d --build miner
echo "Mining service has been started."
elif [ "{{action}}" = "down" ]; then
echo "Stopping mining service"
if docker compose --profile miner stop miner; then
echo "Mining service has been stopped."
else
echo "Error: Failed to stop mining service."
exit 1
fi
else
echo "Unknown action: {{action}}"
echo "Available actions: up, down"
exit 1
fi
# Deprecated: Use 'just prover' instead
broker action="up" env_file="" detached="true":
#!/usr/bin/env bash
echo "Warning: 'just broker' is deprecated. Use 'just prover' instead." >&2
just prover "{{action}}" "{{env_file}}" "{{detached}}"
echo "Warning: 'just broker' is deprecated. Use 'just prover' instead." >&2

# Run the setup script
bento-setup:
Expand Down
Loading