Skip to content

Integration test for @bpmn-io/properties-panel@3.26.3 #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Mar 24, 2025

Note

The issue was found in @bpmn-io/properties-panel v3.26.3

Related to: bpmn-io/properties-panel#404
Discussion: bpmn-io/properties-panel#404 (comment), https://camunda.slack.com/archives/GP70M0J6M/p1742391873712439

Upstream PR: bpmn-io/properties-panel#405

  • Issue was resolved but was not able to reproduce the test case in properties-panel

Proposed Changes

  • added Integration test to check input FEEL field value when switching fields. The value should not propagate to other same field when switching.
Screen.Recording.2025-03-24.at.00.59.51.mov

You can test the implementation here

npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel -l bpmn-io/properties-panel#ideation-abdul

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 24, 2025
@abdul99ahad abdul99ahad marked this pull request as draft March 24, 2025 00:03
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Mar 24, 2025
@abdul99ahad abdul99ahad force-pushed the abdul-test-1 branch 2 times, most recently from 2664e11 to 13888b2 Compare March 25, 2025 20:37
abdul99ahad added a commit to bpmn-io/properties-panel that referenced this pull request Apr 30, 2025
- onblur updates the value async
- trims the whitespaces if exists
- applied to feel-textfield and feel-textarea
Closes #404
Related to: #309 post work

Integration tests: bpmn-io/bpmn-js-properties-panel#1118

test(feel): added testcases
abdul99ahad added a commit to bpmn-io/properties-panel that referenced this pull request Apr 30, 2025
- onblur updates the value async
- trims the whitespaces if exists
- applied to feel-textfield and feel-textarea
Closes #404
Related to: #309 post work

Integration tests: bpmn-io/bpmn-js-properties-panel#1118
abdul99ahad added a commit to bpmn-io/properties-panel that referenced this pull request May 5, 2025
- onblur updates the value async
- trims the whitespaces if exists
- applied to feel-textfield and feel-textarea
Closes #404
Related to: #309 post work

Integration tests: bpmn-io/bpmn-js-properties-panel#1118
abdul99ahad added a commit to bpmn-io/properties-panel that referenced this pull request May 12, 2025
- onblur updates the value async
- trims the whitespaces if exists
- applied to feel-textfield and feel-textarea
Closes #404
Related to: #309 post work

Integration tests: bpmn-io/bpmn-js-properties-panel#1118
barmac pushed a commit to bpmn-io/properties-panel that referenced this pull request May 13, 2025
- onblur updates the value async
- trims the whitespaces if exists
- applied to feel-textfield and feel-textarea

Closes #404
Related to #309

Integration tests: bpmn-io/bpmn-js-properties-panel#1118
barmac pushed a commit to bpmn-io/properties-panel that referenced this pull request May 14, 2025
- onblur updates the value async
- trims the whitespaces if exists
- applied to feel-textfield and feel-textarea

Closes #404
Related to #309

Integration tests: bpmn-io/bpmn-js-properties-panel#1118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Currently worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant