Skip to content

Conversation

kib
Copy link

@kib kib commented Nov 19, 2024

Supports flowchart-elk and makes the naming or direction of a graph optional

closes #149 and #150

Supports flowchart-elk and makes the naming or direction of a graph optional
@bpruitt-goddard
Copy link
Owner

Thanks for the contribution!
Just a few comments:

  1. I think the capture group around (-elk) is messing with the other captures. I think it needs to be something like a non-capture group ((?:-elk)). This is interferring with the capture group highlighting, resulting in the -elk getting highlighted instead of the direction:
    image
  2. The * after the -elk is allowing it to match multiple results, which means this (incorrectly) highlights:
    image
  3. While in there anyway, do you think the direction should be clarified to match the existing subgraph regex here? Since currently it allows any string to match rather than the proper directions:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flowchart syntax hilighting not updated to latest changes

2 participants