Add better handling for native dropdowns #140
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better handling for native dropdowns. This feature was recently introduced in the JS repo: browserbase/stagehand#842 so this change is a simple port to python.
This should resolve this issue: #135
Why
Currently native os-level dropdowns are not able to be acted on. My understanding is these UI elements are rendered by the OS and are not part of the DOM which makes them invisible to playwright.
What changed
A straight port of the JS PR: browserbase/stagehand#842
TL;DR: Add a new method
selectOptionFromDropdown
and instructions in the prompt for how to use it. The method uses Playwright'sselect_option
locator method.There is one exception: I didn't overwrite elements with
combobox
role toselect
role in the_clean_structural_nodes
as is in the JS PR. This function has a slightly different implementation than it's JS counterpart and so I didn't want to mess with it especially because the JS PR didn't include a test case for it. Let me know if you want me to add this for the sake of staying consistent with the other repo.Test plan
I ported over the test cases from the JS PR: