-
Notifications
You must be signed in to change notification settings - Fork 2
app start control #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app start control #196
Conversation
Build size impact
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new public API for controlling and customizing the "app start" span in the performance monitoring system. It allows developers to query and manipulate app start spans at runtime through a structured interface.
- Adds
IAppStartSpanControl
interface with methods to set and clear span types - Implements a
SpanControlRegistry
system for managing different span control types - Exposes
GetSpanControl<T>
method in the publicBugsnagPerformance
API
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
SpanControl.cs | Defines public interfaces and query objects for span control |
BugsnagPerformance.cs | Adds GetSpanControl method and registers SpanControlRegistry |
SpanControlRegistry.cs | Internal registry that maps queries to span control implementations |
AppStartSpanControl.cs | Implementation of IAppStartSpanControl for app start span manipulation |
AppStartHandler.cs | Exposes GetAppStartSpan method for registry access |
Test scenarios | Adds test cases for span customization and clearing functionality |
CHANGELOG.md | Documents the new feature addition |
BugsnagPerformance/Assets/BugsnagPerformance/Scripts/Public/SpanControl.cs
Outdated
Show resolved
Hide resolved
BugsnagPerformance/Assets/BugsnagPerformance/Scripts/Public/SpanControl.cs
Outdated
Show resolved
Hide resolved
BugsnagPerformance/Assets/BugsnagPerformance/Scripts/Internal/SpanControlRegistry.cs
Outdated
Show resolved
Hide resolved
BugsnagPerformance/Assets/BugsnagPerformance/Scripts/Internal/SpanControlRegistry.cs
Outdated
Show resolved
Hide resolved
BugsnagPerformance/Assets/BugsnagPerformance/Scripts/Internal/SpanControlRegistry.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ag-unity-performance into plat-14549-appStartControl
Goal
Adds a new mechanism to control the “app start” span by exposing a public API for querying and manipulating that span.
Changeset
Introduces
IAppStartSpanControl
interface andSpanType
query objects.Registers a
SpanControlRegistry
at startup and exposesGetSpanControl<T>
inBugsnagPerformance
.Implements AppStartSpanControl and wires it through AppStartHandler to the public API.
Testing
Added E2E tests