Skip to content

app start control #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 13, 2025
Merged

app start control #196

merged 9 commits into from
Aug 13, 2025

Conversation

richardelms
Copy link
Contributor

@richardelms richardelms commented Jul 16, 2025

Goal

Adds a new mechanism to control the “app start” span by exposing a public API for querying and manipulating that span.

Changeset

Introduces IAppStartSpanControl interface and SpanType query objects.
Registers a SpanControlRegistry at startup and exposes GetSpanControl<T> in BugsnagPerformance.
Implements AppStartSpanControl and wires it through AppStartHandler to the public API.

Testing

Added E2E tests

@richardelms richardelms requested a review from Copilot July 16, 2025 12:58
Copilot

This comment was marked as outdated.

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Aug 4, 2025

Build size impact

Format Size impact of Bugsnag (kB)
IL2CPP APK 2.38
IL2CPP IPA 2.69

Generated by 🚫 Danger

@richardelms richardelms requested a review from Copilot August 5, 2025 08:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new public API for controlling and customizing the "app start" span in the performance monitoring system. It allows developers to query and manipulate app start spans at runtime through a structured interface.

  • Adds IAppStartSpanControl interface with methods to set and clear span types
  • Implements a SpanControlRegistry system for managing different span control types
  • Exposes GetSpanControl<T> method in the public BugsnagPerformance API

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
SpanControl.cs Defines public interfaces and query objects for span control
BugsnagPerformance.cs Adds GetSpanControl method and registers SpanControlRegistry
SpanControlRegistry.cs Internal registry that maps queries to span control implementations
AppStartSpanControl.cs Implementation of IAppStartSpanControl for app start span manipulation
AppStartHandler.cs Exposes GetAppStartSpan method for registry access
Test scenarios Adds test cases for span customization and clearing functionality
CHANGELOG.md Documents the new feature addition

richardelms and others added 3 commits August 5, 2025 10:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ag-unity-performance into plat-14549-appStartControl
@richardelms richardelms marked this pull request as ready for review August 8, 2025 10:45
@richardelms richardelms requested a review from lemnik August 11, 2025 14:14
@richardelms richardelms merged commit 5467167 into next Aug 13, 2025
4 checks passed
@richardelms richardelms deleted the plat-14549-appStartControl branch August 13, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants