Skip to content

2916 #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 25, 2025
Merged

2916 #2924

merged 8 commits into from
Aug 25, 2025

Conversation

ivicac
Copy link
Contributor

@ivicac ivicac commented Aug 14, 2025

No description provided.

Copilot

This comment was marked as outdated.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the security configuration system to use a modular, contributor-based approach for managing web security rules across different modules. The refactoring introduces new interfaces and moves hardcoded security configurations into pluggable contributors, improving modularity and maintainability.

  • Replaced hardcoded security rules with contributor-based configuration system
  • Introduced new interfaces (AuthorizeHttpRequestContributor, CsrfContributor, SpaWebFilterContributor, etc.) for modular security configuration
  • Renamed and moved authentication filters and providers to follow consistent naming conventions

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
platform-security-web API interfaces Defines new contributor interfaces for modular security configuration
SecurityConfiguration.java Refactored to use contributor pattern instead of hardcoded rules
Various authentication filters Renamed from generic names to module-specific names and updated parent class references
Contributor implementations Added module-specific implementations of the new contributor interfaces
Build files Added dependencies on platform-security-web-api module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@igorbeslic igorbeslic merged commit ec2f3aa into master Aug 25, 2025
7 checks passed
@igorbeslic igorbeslic deleted the 2916 branch August 25, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[task] Add authorizeHttpRequest and ignoringRequestMatcher contributors to avoid hardcoded values in SecurityConfiguration
2 participants