add validation of dynamic_offset #4563
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Fast-Interpreter mode,
wasm_loader_pop_frame_offset
does not validatedynamic_offset
before performing calculations. This can lead to an potential unsigned integer underflow in certain cases, for example whencell_num_to_pop
exceedsdynamic_offset
:wasm-micro-runtime/core/iwasm/interpreter/wasm_loader.c
Line 9869 in cbb6d03
This patch adds a validation step for
dynamic_offset
to prevent such cases and improve code robustness.