Skip to content

Conversation

superajun-wsj
Copy link
Collaborator

No description provided.

@superajun-wsj superajun-wsj force-pushed the jdk25u-target8-jmm-mxbean-fix branch from cdf0d1c to 2f3480f Compare October 17, 2025 06:43
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds JMM MXBean compatibility for HOTSPOT_TARGET_CLASSLIB == 8 by introducing a JDK 8-specific JMM interface, version handling, and related helper functions.

  • Introduces a JDK 8-specific JMM interface (struct, functions, and version handling).
  • Refactors thread-dump logic into a common helper and adds a JDK 8 wrapper without maxDepth.
  • Exposes VM input arguments (string and array) and a JDK 8 diagnostic command-argument info entry point.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/hotspot/share/services/management.cpp Adds JDK 8-specific JMM functions, refactors thread-dump into a common helper, adjusts version return and optional support, and wires a JDK 8 interface table.
src/hotspot/share/include/jmm.h Defines JDK 8-specific JMM version, optional support bit, and the JDK 8 interface struct and signatures.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant