Skip to content

fix: ensure screen capture uses primary display source (close: #116) #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

skychx
Copy link
Collaborator

@skychx skychx commented Feb 19, 2025

ensure screen capture uses primary display source

Close #116

@skychx skychx linked an issue Feb 19, 2025 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented Feb 19, 2025

CLA assistant check
All committers have signed the CLA.

@skychx skychx changed the title fix: ensure screen capture uses primary display source (close: #38) fix: ensure screen capture uses primary display source (close: #116) Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 18.58%. Comparing base (c58b6ef) to head (6a3c86f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/main/main.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   17.98%   18.58%   +0.59%     
==========================================
  Files          61       61              
  Lines        1379     1383       +4     
  Branches      211      211              
==========================================
+ Hits          248      257       +9     
+ Misses       1104     1099       -5     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ycjcl868 ycjcl868 merged commit d395330 into main Feb 19, 2025
10 checks passed
@ycjcl868 ycjcl868 deleted the feat/multi-screen-use-main-screen branch February 19, 2025 07:21
ycjcl868 pushed a commit that referenced this pull request Feb 20, 2025
* fix: ensure screen capture uses primary display source

* test: add device.test.ts

* test: update device.test.ts
ycjcl868 added a commit that referenced this pull request Feb 20, 2025
* fix(bug): ensure screen capture uses primary display source (#117)

* fix: ensure screen capture uses primary display source

* test: add device.test.ts

* test: update device.test.ts

* tweak(ux): close Settings Window after saving (#115)

* feat(visualizer): reduce html report size (close: #118) (#119)

* feat(visualizer): reduce html report size

* feat(visualizer): remove midscene_report_tpl element and minify css & js code

* feat(visualizer): externals common lib

* feat: init sdk

* chore: operators

* feat: sdk agent

* feat: sdk ready

* chore: add publish beta shell

* feat: packages changelog

* release: publish beta packages

* chore: remove pre pack

* refactor(agent): use @ui-tars/sdk refactor

* chore: type

* chore: beta shell

* chore: add utio

* chore: remove app agent code

* release: publish beta packages

* chore: version

* fix: async_hooks

* chore: unsafe

* chore: forge

* fix(build): front end bundle server code

* release: publish beta packages

* chore: status

* fix(operator): scaleFactor

* fix: scaleFactor

* chore: unused

* fix: model retry bug

* fix: som bug

* fix: windows screenshot size

* fix: resize screenshot

* fix: scale factor

* release: publish beta packages

* fix: sdk add parsedPrediction

* chore: utio version

* release: publish beta packages

* fix: useConfig bug

* chore: peer deps

* fix: model custom

* chore: typo

* fix(sdk): async_hooks store get undefined multiple sdk versions in the project

* fix: screen sources primary

* chore: ci test

* chore: replace inquirer to clack

* chore: date.now

* feat: support pass InstanceType model

* release: publish beta packages

* fix: operator bug

* release: publish beta packages

* chore: add instruction

* chore: sdk add maxLoopCount

* chore: simplify sdk

* refactor: useConfig to useContext

* release: publish beta packages

* chore: useContext

* fix: global this

* chore: browser

* chore: add test cases

* feat: init sdk

* chore: unused

---------

Co-authored-by: Dugyu <duguangyu.d@bytedance.com>
Co-authored-by: skychx <skychx@hotmail.com>
Co-authored-by: heh <38528320+ZhaoHeh@users.noreply.github.com>
@ycjcl868 ycjcl868 mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: In a multi-screen setup, it might capture the wrong screen
3 participants