feat(tool): browser search bing engine & app updater #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ycjcl868
commented
Mar 21, 2025
ycjcl868
commented
- feat(tool): browser search bing engine
- feat(agent-tars): app updater
ycjcl868
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
========================================
- Coverage 4.70% 4.69% -0.01%
========================================
Files 253 253
Lines 7756 7769 +13
Branches 1447 1450 +3
========================================
Hits 365 365
- Misses 7351 7364 +13
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ulivz
approved these changes
Mar 21, 2025
ulivz
reviewed
Mar 24, 2025
| pageFunction: searchEngine.extractSearchResults, | ||
| pageFunctionParams: [], | ||
| beforePageLoad: async (page) => { | ||
| await interceptRequest(page); | ||
| }, | ||
| afterPageLoad: async (page) => { | ||
| await page.waitForSelector('.b_pag'); |
There was a problem hiding this comment.
这个是不是会导致 local browser search 只能在 bing 下面工作？baidu 现在现在不 work 了
| @@ -119,11 +121,17 @@ export class BrowserSearch { | |||
|
|
|||
| let links = await browser.evaluateOnNewPage({ | |||
| url, | |||
| waitForOptions: { | |||
| waitUntil: 'networkidle0', | |||
There was a problem hiding this comment.
这里还有个 Breaking Change，之前 Browser Search 是采用默认值 networkidle2，现在是 networkidle0，Browser Search 这种场景 networkidle2 应该够用了
Refs：
- 如果你需要尽快捕获页面（比如只需要 DOM 加载完成，不关心后续的异步请求），用 networkidle2。
- 如果你需要确保页面所有资源（包括图片、脚本等）都加载完成，用 networkidle0。
There was a problem hiding this comment.
试了下 networkidle2 拿不到数据，失败概率比较高
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.