Skip to content

feat(agent-tars): support "view logs" for trouble shooting #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

ulivz
Copy link
Member

@ulivz ulivz commented Mar 22, 2025

Summary

This pull request integrates a logger utility to replace console statements across multiple modules, improving maintainability and debugging within the agent-tars application. Key changes include enhanced search functionality and sensitive data masking in logs. Dependency updates such as adding @agent-infra/logger are also included.

Other Changes

Additional minor changes comprise the application menu setup in the createWindow function and introducing a maskSensitiveData utility for secure logging.

if (this.logFilePath) {
try {
const timestamp = new Date().toISOString();
await fs.appendFile(this.logFilePath, `[${timestamp}] ${message}\n`);

Check warning

Code scanning / CodeQL

Network data written to file Medium

Write to file system depends on
Untrusted data
.
Write to file system depends on
Untrusted data
.
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 160 lines in your changes missing coverage. Please review.

Project coverage is 4.62%. Comparing base (ec61134) to head (8a49ae4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
apps/agent-tars/src/main/utils/logger.ts 0.00% 59 Missing ⚠️
apps/agent-tars/src/main/menu.ts 0.00% 27 Missing ⚠️
...pps/agent-tars/src/main/utils/maskSensitiveData.ts 0.00% 18 Missing ⚠️
apps/agent-tars/src/main/ipcRoutes/llm.ts 0.00% 12 Missing ⚠️
apps/agent-tars/src/main/ipcRoutes/action.ts 0.00% 11 Missing ⚠️
apps/agent-tars/src/main/index.ts 0.00% 10 Missing ⚠️
apps/agent-tars/src/main/llmProvider/index.ts 0.00% 5 Missing ⚠️
apps/agent-tars/src/main/utils/extractToolNames.ts 0.00% 4 Missing ⚠️
apps/agent-tars/src/main/customTools/search.ts 0.00% 3 Missing ⚠️
...pps/agent-tars/src/main/utils/systemPermissions.ts 0.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #269      +/-   ##
========================================
- Coverage   4.69%   4.62%   -0.08%     
========================================
  Files        253     257       +4     
  Lines       7769    7897     +128     
  Branches    1450    1472      +22     
========================================
  Hits         365     365              
- Misses      7364    7492     +128     
  Partials      40      40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ulivz ulivz force-pushed the feat/log-window branch from cb52bf7 to 86e5980 Compare March 22, 2025 19:06
@ulivz ulivz changed the title WIP: feat(agent-tars): support "view logs" for trouble shooting feat(agent-tars): support "view logs" for trouble shooting Mar 22, 2025
@ulivz ulivz force-pushed the feat/log-window branch from 86e5980 to 8a49ae4 Compare March 22, 2025 19:08
@ulivz ulivz requested a review from ycjcl868 March 22, 2025 19:12
@ulivz ulivz merged commit 7861b96 into main Mar 22, 2025
8 of 10 checks passed
@ulivz ulivz deleted the feat/log-window branch March 22, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant