Skip to content

fix(ui-tars): where closing an Electron window in fullscreen mode leaves a black window #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

skychx
Copy link
Collaborator

@skychx skychx commented May 8, 2025

Summary

electron/electron#20263 (comment)

Checklist

  • Added or updated necessary tests (Optional).
  • Updated documentation to align with changes (Optional).
  • Verified no breaking changes, or prepared solutions for any occurring breaking changes (Optional).
  • My change does not involve the above items.

@skychx skychx requested a review from ZhaoHeh May 8, 2025 07:50
@skychx skychx merged commit a4fbd7b into main May 8, 2025
9 checks passed
@skychx skychx deleted the fix/fullscreen-close-blackscreen branch May 8, 2025 07:53
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 4.40%. Comparing base (fa3cdcc) to head (e7b9508).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apps/ui-tars/src/main/window/index.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #575      +/-   ##
========================================
- Coverage   4.40%   4.40%   -0.01%     
========================================
  Files        288     288              
  Lines       9151    9159       +8     
  Branches    1725    1727       +2     
========================================
  Hits         403     403              
- Misses      8695    8703       +8     
  Partials      53      53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants