Skip to content

Fix building arm64 docker image #7093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix building arm64 docker image #7093

wants to merge 1 commit into from

Conversation

tamalsaha
Copy link

@tamalsaha tamalsaha commented Jul 24, 2025 •
edited
Loading

What changed?
Using correct version of dockerize binary in docker image for ARM64

Why?

How did you test it?

docker buildx create \
  --name container \
  --driver=docker-container

## Build & push image
docker build --push \
  --builder container --platform linux/amd64,linux/arm64 \
  --build-arg TARGET=auto-setup \
  -t ghcr.io/appscodeci/cadence-server:master-auto-setup .

Potential risks

Release notes

Documentation Changes

taylanisikdemir
taylanisikdemir reviewed Jul 24, 2025
View reviewed changes
@tamalsaha tamalsaha force-pushed the multiarch branch 3 times, most recently from 70abceb to 291187e Compare July 29, 2025 00:05
@tamalsaha
Copy link
Author 

Wrong Go version in file /cadence/Dockerfile:
	FROM golang:1.23.4-alpine3.21 AS builder
FROM golang:1.24-alpine AS dockerize
Makefile pins Go to go1.23.4, Dockerfiles and GitHub workflows should too.

github.com/jwilder/dockerize v0.9.4 needs Go 1.24 to build. Should I update this project to also use Go 1.24?

@taylanisikdemir
Copy link
Member 

Wrong Go version in file /cadence/Dockerfile:
	FROM golang:1.23.4-alpine3.21 AS builder
FROM golang:1.24-alpine AS dockerize
Makefile pins Go to go1.23.4, Dockerfiles and GitHub workflows should too.

github.com/jwilder/dockerize v0.9.4 needs Go 1.24 to build. Should I update this project to also use Go 1.24?

@Groxx is looking at go 1.24 upgrade. Once that's done we can merge this PR.

@taylanisikdemir
Copy link
Member 

Wrong Go version in file /cadence/Dockerfile:
	FROM golang:1.23.4-alpine3.21 AS builder
FROM golang:1.24-alpine AS dockerize
Makefile pins Go to go1.23.4, Dockerfiles and GitHub workflows should too.

github.com/jwilder/dockerize v0.9.4 needs Go 1.24 to build. Should I update this project to also use Go 1.24?

@Groxx is looking at go 1.24 upgrade. Once that's done we can merge this PR.

@tamalsaha Looks like go1.24 migration will not be trivial at this point. #7111
You may consider unblocking yourself without changing go version in docker files

@tamalsaha
Build docker multi-arch image
ed1b395 
Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha
Copy link
Author

I have downgraded dockerize to v0.9.3 which seems to compile using 1.23.4

https://github.com/jwilder/dockerize/blob/v0.9.3/go.mod#L3

@Groxx Groxx mentioned this pull request Aug 8, 2025
Merged
@demirkayaender demirkayaender mentioned this pull request Aug 8, 2025
Open
@Groxx Groxx closed this in #7149 Aug 8, 2025
pull bot pushed a commit to kokizzu/cadence that referenced this pull request Aug 8, 2025
@Groxx
Use a target-arch-compatible (and more up to date) version of dockeri…
cdf2889 
…ze (cadence-workflow#7149)

Hopefully fixes cadence-workflow#7093 in a simpler way.

Tested with `docker run ... dockerize --help` on two machines with arm64 and amd64 and it seems to work, though the `ARG TARGETARCH` appears to require `docker buildx` or manual entry.  That's a bit awkward for my test-machines (no buildx), but seems likely fine as github actions uses that for build-and-push.

And checked the final in-container docker.yml file that it generates, and it both ran fine and looks essentially identical.  
So this seems safe enough.
If we have issues, people can downgrade and we can revert (though revert will not restore a working arm image for new attempts.  but that's also broken now).
@Groxx
Copy link
Member

Groxx commented Aug 9, 2025

hmm. did this auto-close because of my commit message...? if so, I should see if I can disable that for myself, or word a lot more carefully or something :\

I didn't mean to close this, though it probably can be closed.

@tamalsaha
Copy link
Author

No worries. Your fix works.

@Groxx Groxx mentioned this pull request Sep 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taylanisikdemir taylanisikdemir taylanisikdemir left review comments

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tamalsaha @taylanisikdemir @Groxx