refactor(active-active): Refactor mutable state to accept currentVersion as input #7311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
force-pushed
the
ms
branch
2 times, most recently
from
5193d8f to
6d0e527
Compare
Shaddoll
requested review from
3vilhamster,
Groxx,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Shaddoll
commented
Oct 9, 2025
| e.shard, | ||
| e.logger, | ||
| e.domainEntry, | ||
| e.domainEntry.GetFailoverVersion(), |
There was a problem hiding this comment.
This will be updated in a follow-up PR, because I don't want to mess up with the tests
davidporter-id-au
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactor mutable state to accept currentVersion as input
Why?
A change prepared for history refactoring
How did you test it?
unit tests & simulation tests
Potential risks
Release notes
Documentation Changes