feat: Per program audio sliders #859

eratoriele · 2025-10-29T09:38:47Z

I have added a per program volume slider that can be set to only show active sources

This is my first time handling QML so please let me know about any problems, as I am sure I made many here. Especially on my use of PwObjectTracker,

Side note: This is far-fetched, but on my machine I am getting an error from LogindManager so for my local copy I disabled those lines out of laziness, however I kept them as-is in this PR. I do not think this would result in any breaking behavior but I guessed I should still mention that

added an optional per program volume slider in the modules/bar/popouts/audio

onMoved function of program sliders were not pointing to parent and would result in a ReferenceError

removed trailing spaces and lines with only indentation

soramanew

Nice PR!

soramanew · 2025-10-29T14:19:28Z

modules/bar/popouts/Audio.qml

+            PwNodeLinkTracker {
+              id: linkTracker
+              node: Pipewire.defaultAudioSink
+            }
+            PwObjectTracker {
+                objects: [linkTracker.linkGroups]
+            }


No need for this, add a streams property to the Audio service instead, then use that.

So in services/Audio.qml:

diff --git a/services/Audio.qml b/services/Audio.qml index 71ccb86..a36d79c 100644 --- a/services/Audio.qml +++ b/services/Audio.qml @@ -14,7 +14,9 @@ Singleton { property string previousSourceName: "" readonly property var nodes: Pipewire.nodes.values.reduce((acc, node) => { - if (!node.isStream) { + if (node.isStream) { + acc.streams.push(node); + } else { if (node.isSink) acc.sinks.push(node); else if (node.audio) @@ -22,10 +24,12 @@ Singleton { } return acc; }, { + streams: [], sources: [], sinks: [] }) + readonly property list<PwNode> streams: nodes.streams readonly property list<PwNode> sinks: nodes.sinks readonly property list<PwNode> sources: nodes.sources

soramanew · 2025-10-29T14:19:51Z

modules/bar/popouts/Audio.qml

+                font.weight: 500
+            }
+            Repeater {
+                model: linkTracker.linkGroups.filter(e => e.source.isStream)


Use Audio.streams

soramanew · 2025-10-29T14:21:25Z

modules/bar/popouts/Audio.qml

+                                if (modelData.source.audio.muted)
+                                    return "no_sound";
+                                if (modelData.source.audio.volume >= 0.5)
+                                    return "volume_up";
+                                if (modelData.source.audio.volume > 0)
+                                    return "volume_down";
+                                return "volume_mute";


Use Icons.getVolumeIcon

PixelKhaos · 2025-10-29T15:34:34Z

Oh nice PR, I was working on a volume mixer widget myself for the dashboard, but got sidetracked haha
Could be cool to use this to create that in addition for something prettified and condensed widget, could be nice to have some way to filter to specific applications only in a list (I sometimes get quite a lot of "active" streams).

eratoriele · 2025-10-29T16:34:46Z

I am currently working on the Audio.streams. However when I try to use PwNodeLinkTracker on these nodes under the repeater with:

    Repeater {
          model: Audio.streams
          ColumnLayout {
              required property PwNode modelData
              PwNodeLinkTracker {
                  id: linkTracker
                  node: modelData
              }
              PwObjectTracker {
                  objects: [modelData]
              }
              Layout.topMargin: Appearance.spacing.small
              ...
          }
     }

linkTracker.linkGroups returns an empty array. I am assuming this has got something to do with whether the node is a sink or not. Which then means I can not filter by link group's state.

could be nice to have some way to filter to specific applications only in a list (I sometimes get quite a lot of "active" streams).

I didn't really consider any other forms of filtering tbh. I might try to think of another method that doesn't require the linkGroup

soramanew · 2025-10-30T03:55:38Z

Can you not just use the streams directly? Why do you need the link tracker?

Also, I was thinking, for a full audio mixer, we might want to have it in a separate page in the control centre instead of having it in the popout

…to control centre (faulty) currently has problems with heights of the components added an extra property to recording's prop value to track mixer accordion state added streams list to Audio service removed the audioPopup config values

eratoriele · 2025-10-30T19:35:18Z

Can you not just use the streams directly? Why do you need the link tracker?

Since the sliders were on the audio popup, I thought having too may of them on that popout wouldn't look good so I tried to filter them by their link states

Also, I was thinking, for a full audio mixer, we might want to have it in a separate page in the control centre instead of having it in the popout

I first tried to place these in the popout since that is where I launch pavucontrol from
For now I have given up on filtering streams by their states so I experimented with placing it in the control centre like you said which looks like this:

recording_20251030_22-08-03.mp4

But I couldn't figure out how to handle the height of the accordion properly so it looks really bad right now

Aside from what is visible on the video, to stop the accordion from taking too much space I have copied the same scroll bar from the recordingList. But this isn't ideal because this space now has a bunch of interactable sliders inside a scrollbar which fight clash for the control of the mouse
Another minor note: since the control centre got taller, the dino image on the sidebar doesn't get displayed anymore, at least on my monitor size

PixelKhaos · 2025-10-31T15:02:08Z

For now I have given up on filtering streams by their states so I experimented with placing it in the control centre like you said which looks like this:

I think soramanew meant as a separate page, as in switching context off from the various cards normally in that drawer, to one showing only the volume mixer, maybe with kind of like pagination or tabs like the dashboard, it's intuitively similar to other desktop environments and even Windows.

I personally think vertical column on the left in the control centre for tabs could work, opens up room for organization and sections of different quick controls and so even if there's barely much in terms of new pages quite yet?

soramanew · 2025-10-31T15:37:31Z

That isn't actually the control centre, the control centre is the window that contains the Bluetooth settings

Moved audio mixer to dashboard's media tab and it replaces the bongocat gif if enabled in the config Also added an optional error type to StyledSliders

eratoriele · 2025-11-01T22:09:47Z

That isn't actually the control centre, the control centre is the window that contains the Bluetooth settings

Oh, is the control centre the window that opens after clicking the settings button in the quick toggles menu?
If so, my intention with the PR was to have a quick access, without launching any extra windows. However I am not opposed to componentizing the mixer and also have it be there as well.

After my last failed attempt, I gave up on messing with dynamic heights and accordions. And thought about @PixelKhaos's comment on placing it in the dashboard

I was working on a volume mixer widget myself for the dashboard,

I thought the space bongocat gif is taking could be used for a mixer and put it there if enabled by a new config option

recording_20251102_00-50-03.mp4

let me know what you guys think

I have made a mistake in the if conditions, instead of checking if a node is a stream, I was checking if node is a stream and is a sink, resulting in a situation where a non-stream node would enter the else block

PixelKhaos · 2025-11-02T15:12:32Z

Maybe the waveform and cover section on the left would need to be a bit smaller to allow for more padding for the mixer, so spacing and all gets consistent. Atm it looks a bit crammed in there.

But I do think the dashboard is a good place for a mixer to be fast to access, and does help with not worrying about dynamic height wrapping a scrollable area etc.

In the control centre the mixer could be more granular, show more details and maybe grouping etc, but as a simple mixer widget version I think what ya got is pretty much it!

Also added a Styled Select, however it needs further work done to it

eratoriele · 2025-11-08T17:40:09Z

Maybe the waveform and cover section on the left would need to be a bit smaller to allow for more padding for the mixer, so spacing and all gets consistent. Atm it looks a bit crammed in there.

I think I saw some config options around the dashboard spacing/sizes so I left that part untocuhed, at least for now

In the control centre the mixer could be more granular

I also worked on a prototype for an audio tab for the control centre, which currently looks like this:

recording_20251108_20-14-12.mp4

I will try to move 'programs' part to be in it's own Card, and I want to do further work on the 'StyledSelect' component I have added.

however, besides adding a main volume slider and adding a device selector (which are already present in the bar's audio popup) this page doesn't add any extra utility

I looked at the functionalities pavucontrol has besides what I already have and it seems to be a couple things:

Displaying a real time volume indicator
Ability to change channel balance
Ability to set latency on devices

I am thinking of implementing the first point by having the slider 'blink', as in, change the opacity of the slider by reading the volumes property of PwNodeAudio object. So that currently audio producing sliders have a subtle animation to them.
But personally I don't use the other features myself. So if anyone uses these or any another functionality I didn't mention let me know I guess

and maybe grouping etc

What kind of grouping are you thinking about? Grouping sliders by which application they originate from?

eratoriele added 3 commits October 29, 2025 12:23

bar/popouts/audio: added per program audio sliders

e1568e5

added an optional per program volume slider in the modules/bar/popouts/audio

bar/popouts/audio: fixed program slider onMoved

bd5e7d1

onMoved function of program sliders were not pointing to parent and would result in a ReferenceError

bar/poputs/audio: formatting

840a798

removed trailing spaces and lines with only indentation

soramanew requested changes Oct 29, 2025

View reviewed changes

modules/dashboard/media: moved audio mixer to dashboard

da991e4

Moved audio mixer to dashboard's media tab and it replaces the bongocat gif if enabled in the config Also added an optional error type to StyledSliders

services/Audio: fixed mistake on source/sink/stream populating

437b063

I have made a mistake in the if conditions, instead of checking if a node is a stream, I was checking if node is a stream and is a sink, resulting in a situation where a non-stream node would enter the else block

ControlCentre/Audio: Implemented a basic audio mixer

620cf97

Also added a Styled Select, however it needs further work done to it

Uh oh!

feat: Per program audio sliders #859

Are you sure you want to change the base?

feat: Per program audio sliders #859

Uh oh!

Conversation

eratoriele commented Oct 29, 2025

Uh oh!

soramanew left a comment

Choose a reason for hiding this comment

Uh oh!

soramanew Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

soramanew Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

soramanew Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

PixelKhaos commented Oct 29, 2025

Uh oh!

eratoriele commented Oct 29, 2025

Uh oh!

soramanew commented Oct 30, 2025

Uh oh!

eratoriele commented Oct 30, 2025

Uh oh!

PixelKhaos commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soramanew commented Oct 31, 2025

Uh oh!

eratoriele commented Nov 1, 2025

Uh oh!

PixelKhaos commented Nov 2, 2025

Uh oh!

eratoriele commented Nov 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PixelKhaos commented Oct 31, 2025 •

edited

Loading