-
Notifications
You must be signed in to change notification settings - Fork 15
Change fields to bignumeric to accept values on NTD track and roadway tables #4319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erikamov
wants to merge
1
commit into
main
Choose a base branch
from
mov/4276-bignumeric
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform plan in iac/cal-itp-data-infra/airflow/us Plan: 0 to add, 6 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# google_storage_bucket_object.calitp-composer["dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_by_agency.yml"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer" {
!~ crc32c = "KHlMmg==" -> (known after apply)
!~ detect_md5hash = "uRPAddNpBxu55bSEcsJXUw==" -> "different hash"
!~ generation = 1751416670797784 -> (known after apply)
id = "calitp-composer-dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_by_agency.yml"
!~ md5hash = "uRPAddNpBxu55bSEcsJXUw==" -> (known after apply)
name = "dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_by_agency.yml"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer["dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_guideway_age_distribution.yml"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer" {
!~ crc32c = "P/3SfA==" -> (known after apply)
!~ detect_md5hash = "JOT0WP0nNhmu8B3uo+Pjjg==" -> "different hash"
!~ generation = 1751416671712936 -> (known after apply)
id = "calitp-composer-dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_guideway_age_distribution.yml"
!~ md5hash = "JOT0WP0nNhmu8B3uo+Pjjg==" -> (known after apply)
name = "dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_guideway_age_distribution.yml"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer-catalog will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer-catalog" {
!~ content = (sensitive value)
!~ crc32c = "jt477Q==" -> (known after apply)
!~ detect_md5hash = "Z2vrtASxHLJuhHV3ixiaHQ==" -> "different hash"
!~ generation = 1758311274485789 -> (known after apply)
id = "calitp-composer-data/warehouse/target/catalog.json"
!~ md5hash = "Z2vrtASxHLJuhHV3ixiaHQ==" -> (known after apply)
name = "data/warehouse/target/catalog.json"
# (16 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer-dags["models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_by_agency.sql"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer-dags" {
!~ crc32c = "NC5+jw==" -> (known after apply)
!~ detect_md5hash = "R4tcH7NdmHfuZrzmf+vOcA==" -> "different hash"
!~ generation = 1751997660679903 -> (known after apply)
id = "calitp-composer-data/warehouse/models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_by_agency.sql"
!~ md5hash = "R4tcH7NdmHfuZrzmf+vOcA==" -> (known after apply)
name = "data/warehouse/models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_by_agency.sql"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer-dags["models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_guideway_age_distribution.sql"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer-dags" {
!~ crc32c = "kqY7Pg==" -> (known after apply)
!~ detect_md5hash = "nMv4jZ15Vi/7caFto0d1Ew==" -> "different hash"
!~ generation = 1751997659670018 -> (known after apply)
id = "calitp-composer-data/warehouse/models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_guideway_age_distribution.sql"
!~ md5hash = "nMv4jZ15Vi/7caFto0d1Ew==" -> (known after apply)
name = "data/warehouse/models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_guideway_age_distribution.sql"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer-manifest will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer-manifest" {
!~ content = (sensitive value)
!~ crc32c = "qWGFow==" -> (known after apply)
!~ detect_md5hash = "9++V7UQTvHJxJ90vsnG18A==" -> "different hash"
!~ generation = 1758311276222460 -> (known after apply)
id = "calitp-composer-data/warehouse/target/manifest.json"
!~ md5hash = "9++V7UQTvHJxJ90vsnG18A==" -> (known after apply)
name = "data/warehouse/target/manifest.json"
# (16 unchanged attributes hidden)
}
Plan: 0 to add, 6 to change, 0 to destroy. 📝 Plan generated in Plan Terraform for Warehouse and DAG changes #680 |
Terraform plan in iac/cal-itp-data-infra-staging/airflow/us Plan: 0 to add, 4 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# google_storage_bucket_object.calitp-staging-composer["dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_by_agency.yml"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer" {
!~ crc32c = "KHlMmg==" -> (known after apply)
!~ detect_md5hash = "uRPAddNpBxu55bSEcsJXUw==" -> "different hash"
!~ generation = 1749661093934904 -> (known after apply)
id = "calitp-staging-composer-dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_by_agency.yml"
!~ md5hash = "uRPAddNpBxu55bSEcsJXUw==" -> (known after apply)
name = "dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_by_agency.yml"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer["dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_guideway_age_distribution.yml"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer" {
!~ crc32c = "P/3SfA==" -> (known after apply)
!~ detect_md5hash = "JOT0WP0nNhmu8B3uo+Pjjg==" -> "different hash"
!~ generation = 1758573915692947 -> (known after apply)
id = "calitp-staging-composer-dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_guideway_age_distribution.yml"
!~ md5hash = "JOT0WP0nNhmu8B3uo+Pjjg==" -> (known after apply)
name = "dags/create_external_tables/ntd_data_products/multi_year__track_and_roadway_guideway_age_distribution.yml"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer-dags["models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_by_agency.sql"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer-dags" {
!~ crc32c = "NC5+jw==" -> (known after apply)
!~ detect_md5hash = "R4tcH7NdmHfuZrzmf+vOcA==" -> "different hash"
!~ generation = 1751997660074376 -> (known after apply)
id = "calitp-staging-composer-data/warehouse/models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_by_agency.sql"
!~ md5hash = "R4tcH7NdmHfuZrzmf+vOcA==" -> (known after apply)
name = "data/warehouse/models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_by_agency.sql"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer-dags["models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_guideway_age_distribution.sql"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer-dags" {
!~ crc32c = "kqY7Pg==" -> (known after apply)
!~ detect_md5hash = "nMv4jZ15Vi/7caFto0d1Ew==" -> "different hash"
!~ generation = 1758573915686918 -> (known after apply)
id = "calitp-staging-composer-data/warehouse/models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_guideway_age_distribution.sql"
!~ md5hash = "nMv4jZ15Vi/7caFto0d1Ew==" -> (known after apply)
name = "data/warehouse/models/staging/ntd_annual_reporting/stg_ntd__track_and_roadway_guideway_age_distribution.sql"
# (17 unchanged attributes hidden)
}
Plan: 0 to add, 4 to change, 0 to destroy. 📝 Plan generated in Plan Terraform for Warehouse and DAG changes #680 |
ce75dd0
to
ada95a9
Compare
… roadway tables. [#4276]
ada95a9
to
7f9547f
Compare
ohrite
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍐 w/ @erikamov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the data type from
NUMERIC
toBIGNUMERIC
to fixInvalid NUMERIC value
error accepting longer values onexternal_ntd__annual_reporting.multi_year__track_and_roadway_by_agency
.sum_total_track_miles
andexternal_ntd__annual_reporting.multi_year__track_and_roadway_guideway_age_distribution
fields:_1940s
,_1950s
,_1960s
,_1970s
,_1980s
,_1990s
,_2000s
,_2010s
,_2020s
,pre1940s
and downstream tables.Resolves [#4276]
Type of change
How has this been tested?
Tested running all the pipeline on Airflow Staging: external tables DAG and specific tables in dbt_all.
Post-merge follow-ups
Confirm if
dbt_all
is able to run successfullyfct_track_and_roadway_guideway_age_distribution
andfct_track_and_roadway_by_agency
.