fix: toBeDisabled now also evaluates disabled prop when element is Text #1802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1801 by ensuring
Text
components with thedisabled
prop are correctly identified as disabled bycomputeAriaDisabled
.Previously,
computeAriaDisabled
didn't check for thedisabled
prop onText
elements, causing queries likegetByRole('text', { disabled: true })
to fail. The change adds a check to returntrue
whenisHostText(element)
andprops.disabled
are both true, aligningreact-native-testing-library
's behavior with expected accessibility states.Test plan
New unit tests have been added for
computeAriaDisabled
to verify this change. These tests cover:Text
component withdisabled={true}
: AssertscomputeAriaDisabled
returnstrue
.Text
component withoutdisabled
prop ordisabled={false}
: AssertscomputeAriaDisabled
returnsfalse
.Existing
TextInput
behavior: Ensures non-editableTextInput
components are still correctly identified as disabled.aria-disabled
andaccessibilityState.disabled
props: Verifies these existing checks continue to function.The new
computeAriaDisabled
tests should pass, demonstrating correct handling of thedisabled
prop onText
components.